Bug 2164830

Summary:	Include fix to prevent crashing when "dconf update" is run
Product:	[Fedora] Fedora	Reporter:	Jonathan Billings <jbilling>
Component:	gjs	Assignee:	Kalev Lember <klember>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	37	CC:	fzatlouk, gnome-sig, klember, mr.marcelo.barbosa, otaylor, walters
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	gjs-1.74.1-6.fc37	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-01-31 01:57:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jonathan Billings 2023-01-26 15:45:18 UTC

Description of problem:
If you run "dconf update" during a logged in GNOME session that has certain GNOME Shell extensions installed (such as window-list), the session exits unexpectedly.

At first I thought this was a bug in the extension, but it turns out to be a bug in gjs.  I described this problem in https://gitlab.gnome.org/GNOME/gjs/-/issues/510 and it was fixed in https://gitlab.gnome.org/GNOME/gjs/-/commit/9b666e1e99b9352dc52a1dee7345e26a93af92b2 and merged in https://gitlab.gnome.org/GNOME/gjs/-/commit/4e3ab40f893c3e5c201cdb24ff295869077a3cb0

Newer versions of gjs include this fix, but if we are not going to update the version of gjs in Fedora 37, could we include the patch in the current version?  

I've been maintaining my own packages with just this patch added, but every time Fedora updates the package, and I don't notice it, I go back to dconf update crashing my session.

There are Fedora packages that run 'dconf update' as part of the %post scriptlet so it isn't something I can just avoid doing.

Version-Release number of selected component (if applicable):
gjs-1.74.1-5.fc37.x86_64
gnome-shell-extension-window-list-43.0-1.fc37.noarch

How reproducible:
Always

Steps to Reproduce:

1. Install the gnome-shell-extension-window-list package
2. Log into a GNOME session
3. Change a dconf setting in /etc/dconf/db/local.d/
4. Run 'dconf update' as root

Actual results:
Entire GNOME session abruptly exits

Expected results:
The dconf setting is updated.

Comment 1 Kalev Lember 2023-01-26 23:07:34 UTC

Sure, let me backport this.

Comment 2 Fedora Update System 2023-01-27 00:49:25 UTC

FEDORA-2023-a231ec433d has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a231ec433d

Comment 3 Fedora Update System 2023-01-28 01:41:16 UTC

FEDORA-2023-a231ec433d has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a231ec433d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a231ec433d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2023-01-31 01:57:21 UTC

FEDORA-2023-a231ec433d has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.