Bug 2165107

Summary:	Unclear error message with empty --certs-state
Product:	Red Hat Satellite	Reporter:	Radek Mynar <rmynar>
Component:	Installer	Assignee:	Eric Helms <ehelms>
Status:	VERIFIED ---	QA Contact:	Radek Mynar <rmynar>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.13.0	CC:	ehelms, jpathan
Target Milestone:	6.14.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Radek Mynar 2023-01-27 17:36:19 UTC

Description of problem:
When creating new certificates using satellite-installer and passing empty "state" parameter an Evaluation Error is shown

Version-Release number of selected component (if applicable):
-

How reproducible:
always

Steps to Reproduce:
a)
1. satellite-installer --certs-regenerate true --certs-update-all --certs-update-server --certs-update-server-ca --certs-org-unit "FooOrg"  --certs-state ""
b)
1. edit /etc/foreman-installer/scenarios.d/satellite-answers.yaml and set certs -> state: ''   
2. satellite-installer --certs-regenerate true --certs-update-all --certs-update-server --certs-update-server-ca

Actual results:
satellite-installer fails with following error
<timestamp> [ERROR ] [configure] Evaluation Error: Error while evaluating a Function Call, 'katello::build_dn' parameter 'options' index 3 index 1 expects a value of type Undef or String[1], got String (file: /usr/share/foreman-installer/modules/katello/manifests/application.pp, line: 40, column: 24) on node <node-fqdn>

Expected results:
Reasonable error should be shown.

Additional info:
After fix (if this gets fixed) the installer should never cause inconsistency between certificates and config files - 'hammer ping' should pass (see bug 1964037)

Comment 1 Brad Buckingham 2023-01-30 14:14:28 UTC

Is this a regression from prior release?

Thanks!

Comment 2 Radek Mynar 2023-01-31 12:52:39 UTC

This was most probably introduced after fix of bug 1964037, so I suppose it is a regression.

Comment 3 Radek Mynar 2023-06-07 12:06:36 UTC

I tested various combinations (empty string/valid string) of state and org_unit. There was no error message. No combination led to failing 'hammer ping'.

VERIFIED with Satellite 6.14 SNAP2.0 @RHEL8.8