Bug 2165224
| Summary: | Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | blinxen <h-k-81> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-02-12 20:55:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
blinxen
2023-01-28 16:02:50 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5344965 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2165224-rust-fallible_collections/fedora-rawhide-x86_64/05344965-rust-fallible_collections/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service Oh, another library that was rewritten from C in Rust. :D Reading the upstream README, I recommend that use use cargo-c to build the shared library. In my experience, it is the least painful option for building C-style shared libraries, especially because it handles setting SONAME and generating headers and pkg-config files. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Once releng has processed the unretirement, please also request an f37 branch for this package. It makes it much easier for Rust SIG members to update things if there's not "holes" (i.e. this package would be present in rawhide and f36, but not f37, which would be weird). I also recommend to re-enable tracking for the package in koschei for the rawhide and f37 branches once they have been created. I forgot to add: We already use cargo-c for building rav1e (an AV1 encoder library). It might be helpful to look at its spec file to see how to use cargo-c for Fedora RPM builds: https://src.fedoraproject.org/rpms/rust-rav1e/blob/rawhide/f/rust-rav1e.spec#_543-560 > I forgot to add: We already use cargo-c for building rav1e (an AV1 encoder library).
> It might be helpful to look at its spec file to see how to use cargo-c for Fedora RPM builds:
> https://src.fedoraproject.org/rpms/rust-rav1e/blob/rawhide/f/rust-rav1e.spec#_543-560
Thanks for the tip!! Much appreciated since I am still new to the packaging scene :D.
It appears that build of this crate failed in koji - do you need help with debugging the failure? Help would be very much appreciated! I was trying to debug it myself, but I think I don't understand the underlying problem. I have created the following issue in the upstream repository: https://github.com/vcombey/fallible_collections/issues/35 I documented my findings findings there. The only build that is failing, is the i686 build. The package now builds successfully for all targeted branches. Closing this review. |