Bug 2167067

Summary: Review Request: python-uswid - Python module for working with Firmware SBoMs
Product: [Fedora] Fedora Reporter: Richard Hughes <rhughes>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-02-04 15:42:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Richard Hughes 2023-02-04 09:30:28 UTC 
Spec URL: https://people.freedesktop.org/~hughsient/temp/python-uswid.spec
SRPM URL: https://people.freedesktop.org/~hughsient/temp/python-uswid-0.4.1-1.fc37.src.rpm
KOJI URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=97087821
Description:

Software Identification (SWID) tags provide an extensible XML-based structure to
identify and describe individual software components, patches, and installation
bundles. XML SWID tag representations can be too large for devices with network
and storage constraints.

Fedora Account System Username: rhughes
Comment 1 Richard Hughes 2023-02-04 09:31:39 UTC 
rpmlint output:

    python-uswid.spec:44: W: macro-in-comment %{python3}
Comment 2 Jakub Kadlčík 2023-02-04 09:36:31 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5447736
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2167067-python-uswid/fedora-rawhide-x86_64/05447736-python-uswid/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
Comment 3 Richard Hughes 2023-02-04 11:13:24 UTC 
[!]: Reviewer should test that the package builds in mock.
[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0:
     https://files.pythonhosted.org/packages/source/u/uswid/uswid-0.4.1.tar.gz
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/SourceURL/

Blah! I've made sure the source archive exists now -- sorry about that.
Comment 4 Neal Gompa 2023-02-04 14:29:31 UTC 
Review notes:

* Package is named appropriately
* Package follows Fedora Python packaging guidelines
* Package builds and installs
* No serious issues from rpmlint

Looks good to me, so...

PACKAGE APPROVED.
Comment 5 Fedora Admin user for bugzilla script actions 2023-02-04 15:31:19 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-uswid
Comment 6 Fedora Update System 2023-02-04 15:40:50 UTC 
FEDORA-2023-05712b14de has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-05712b14de
Comment 7 Fedora Update System 2023-02-04 15:42:19 UTC 
FEDORA-2023-05712b14de has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 8 Richard Hughes 2023-02-04 15:43:56 UTC 
Thanks again Neal, much appreciated for the speedy review.