Bug 2167216

Summary:	aardvark-dns does not honor standard Fedora compiler flags for Rust
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	aardvark-dns	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED ERRATA	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	38	CC:	bbaude, dwalsh, jnovy, lsm5, mheon, rh.container.bot, tsweeney
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	aardvark-dns-1.5.0-3.fc36 aardvark-dns-1.5.0-4.fc37	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-02-16 01:24:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabio Valentini 2023-02-05 20:54:05 UTC

Currently, aardvark-dns is built without default Fedora compiler flags for Rust code (i.e. "-Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Clink-arg=-Wl,-z,relro -Clink-arg=-Wl,-z,now --cap-lints=warn" on Fedora 37) - essentially, the code is not fully optimized, and does not contain debuginfo or frame pointers.

RUSTFLAGS are the standard environment variable for setting compiler flags for rustc (similar to CFLAGS / CXXFLAGS / LDFLAGS), but they aren't set by default (and not yet included in %set_build_flags, but I've reported an RFE about this).

It appears that aardvark-dns Makefile hard-codes just `--release` flag for cargo, which only implies `-Copt-level=2`. This results in aardvark-dns not having valid debug symbols (explains why rpmbuild fails to generate debuginfo packages!), its code not being optimized to the same level as other Rust code in Fedora, and it not respecting other flags for better code quality and / or debuggability.

Two possible solutions might be to export RUSTFLAGS and have the build process honor these settings, or to invoke `%__cargo` instead of `cargo`, as that macro includes RUSTFLAGS (but might have other side effects).

Comment 1 Ben Cotton 2023-02-07 15:12:49 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 2 Fedora Update System 2023-02-07 16:08:36 UTC

FEDORA-2023-5a6bcfb0fa has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a6bcfb0fa

Comment 3 Fedora Update System 2023-02-07 16:08:37 UTC

FEDORA-2023-9871840a59 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9871840a59

Comment 4 Fedora Update System 2023-02-08 01:29:47 UTC

FEDORA-2023-9871840a59 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-9871840a59`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9871840a59

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2023-02-08 01:40:41 UTC

FEDORA-2023-5a6bcfb0fa has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5a6bcfb0fa`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a6bcfb0fa

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2023-02-10 00:30:58 UTC

FEDORA-2023-9871840a59 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-9871840a59`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9871840a59

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-02-16 01:24:52 UTC

FEDORA-2023-5a6bcfb0fa has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2023-02-17 18:15:58 UTC

FEDORA-2023-9871840a59 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.