Bug 216749
Summary: | When a ppp connection is brought up ONBOOT, ppp-watch doesn't keep running. | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kevin White <fedora-kevin> | ||||
Component: | initscripts | Assignee: | Bill Nottingham <notting> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Brock Organ <borgan> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 6 | CC: | rvokal | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | 8.50-1 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-01-17 17:22:40 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Kevin White
2006-11-21 20:26:33 UTC
I've been staring at the ppp-watch code and found something interesting. If you pass ppp-watch the boot parameter, it sets an alarm signal, which should make it time-out after a configurable amount of time. This is interesting, because that alarm is never canceled, and there's no way to miss it. Which means, if called on-boot, ppp-watch will always end up dying. Even if the pppd connection is working just fine, ppp-watch will end up going away. Is this by design? It's certainly always been that way; as that's been 7+ years, unsure whether it's by design or by history. Does that behavior seem to be correct? It isn't for my purposes, but I can recompile ppp-watch to fix it. I'm staring at the code now, trying to find the right place to put alert(0) in if (boot) once the connection's successfully made. When I figure that out, I'll update the ticket here. Created attachment 145581 [details]
potential patch
Does the attached help? Unfortunately, I'm not in a position where I can test
this at the moment.
That's about what I was going to do. I may wrap it in code to only run if we're in boot mode (because that's the only way alarm could have been set). I will test and confirm that this works, and attach my patch (which will be the same as yours, just with an extra if clause). More later. Shouldn't need the 'if' - alarm(0) is ignored if no prior alarm is set. OK, I applied the patch as written (without the check for boot) and it worked. My patched FC6 box booted with a ppp connection set up ONBOOT, and the corresponding ppp-watch program is still running. Great! This allows ifdown to work much more smoothly. Confirmed: the patch fixes the problem. Added in CVS, will be in 8.50-1. May appear in a future FC6 update. |