Bug 2167534

Summary: anaconda on KDE live now has more KDE-native theming
Product: [Fedora] Fedora Reporter: Adam Williamson <awilliam>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 38CC: anaconda-maint-list, marc, mcatanza, nate, ngompa13, vponcova, vslavik, w
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: openqa
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-02-07 23:41:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
'before' screenshot (anaconda looks much the same as on GNOME)
none
"after" screenshot (anaconda looks much more like a typical KDE/Qt app) none

Description Adam Williamson 2023-02-06 23:55:38 UTC 
This isn't necessarily a problem, but I wanted to make sure everyone is OK with it, so I'm filing a bug. If everyone's OK with it, we can close it.

Up till today, anaconda when run from the KDE live image has looked very much like anaconda run from the Workstation live, or from a traditional installer image. See the 'before' screenshot. Note a few things, particularly:

1. The blue color used for indicating the currently-selected item is quite dark
2. Buttons have rounded corners and quite a lot of padding, the Continue button is solid blue
3. The horizontal separator between Spanish and Afrikaans in the language list is very subtle, barely visible

As of today - I'm not sure precisely what triggered this, the first openQA test that hit it was a test of FEDORA-2023-7ab7e992b0 which is an update to a lot of kf5 components, but it's *possible* some non-package change or non-critpath update is involved - it looks rather different. See the 'after' screenshot. Note:

1. The blue color is much lighter
2. Buttons have squarer corners and less padding, the Continue button is not solid blue, it just has a blue surround
3. The horizontal separator is much more obviously visible

This probably affects all GTK-based apps, but anaconda is the most prominent on our live images. I found a setting page in the KDE control center called "GNOME/GTK Application Style". There's a setting there for "GTK theme", which is a dropdown menu. On older images (which look like the 'before' picture), this setting shows up as a blank entry which does not appear in the dropdown list (which contains the choices Breeze, Default and Emacs). On newer images (which look like the 'after' picture), the setting shows as Breeze. I'm not sure why this changed.

CCing KDE folks, and Workstation folks in case they are concerned about how GTK-based apps look in KDE.
Comment 1 Adam Williamson 2023-02-06 23:56:14 UTC 
Created attachment 1942626 [details]
'before' screenshot (anaconda looks much the same as on GNOME)
Comment 2 Adam Williamson 2023-02-06 23:57:32 UTC 
Created attachment 1942628 [details]
"after" screenshot (anaconda looks much more like a typical KDE/Qt app)
Comment 3 Nate Graham 2023-02-07 00:18:21 UTC 
From the KDE perspective, we're cool with this.
Comment 4 Michael Catanzaro 2023-02-07 00:38:45 UTC 
(In reply to Adam Williamson from comment #0)
> CCing KDE folks, and Workstation folks in case they are concerned about how
> GTK-based apps look in KDE.

I think this should be entirely up to KDE spin developers.
Comment 5 Ben Cotton 2023-02-07 15:08:44 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.
Comment 6 Neal Gompa 2023-02-07 23:32:14 UTC 
I'm pretty okay with this result. :)
Comment 7 Neal Gompa 2023-02-07 23:33:24 UTC 
To elucidate, there was a long-standing bug where the GTK style wasn't fully set properly out of the box on the spin. This seems to have finally resolved itself, which gives us the desired result.
Comment 8 Adam Williamson 2023-02-07 23:41:53 UTC 
anaconda did provide feedback on IRC:

jkonecny[m]
hi, we don't have a strong preference
jkonecny[m]
until KDE folks are happy we don't have any objections

so, with that, it seems like everyone is OK, so I'll close the bug. Personally I do think the buttons look slightly goofy, but hey, I'm just the QA monkey. :P