Bug 216785
Summary: | Review Request: perl-Gnome2-Print - Perl wrappers for the Gnome Print utilities | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | panemade |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Gnome2-Print/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-22 15:46:23 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chris Weyl
2006-11-22 00:03:52 UTC
Tell me how can i use this package or test its working in FC6 core? There are a number of sample scripts that come in the examples directory (or, when the rpm is installed, under %doc). Running one or more of those should enable you to examine the functionailty of the module proper. Did mock build and found under build.log Unrecognized argument in LIBS ignored: '-pthread' Got some rpmlint Warnings W: perl-Gnome2-Print devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/Gnome2/Print/Install/gnomeprintperl-autogen.h A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. W: perl-Gnome2-Print devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/Gnome2/Print/Install/gnomeprintperl-version.h A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. W: perl-Gnome2-Print devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/Gnome2/Print/Install/gnomeprintperl.h A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. are those can be ignored for perl packages?? Those warnings can be safely ignored for perl packages. Not able to find license file(Is am i missing something)? Still Unrecognized argument in LIBS ignored: '-pthread' message coming not understanding which causes this message to appear? (In reply to comment #5) > Not able to find license file(Is am i missing something)? Yes, you are missing something: Nobody is obliged to ship one. Perl module files typically contain licenses embedded into their source files. > Still Unrecognized argument in LIBS ignored: '-pthread' message coming > not understanding which causes this message to appear? IIRC, this is a bug/crappy code somewhere in some of the perl-Gtk/Gnome infrastructure. I recall this had appeared several times before, but I don't recall all details on how this had been resolved. Googling/searching bugzilla might provide further insights. Does that be a blocker? (In reply to comment #7) > Does that be a blocker? I just found a reference: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166252 ... so people seem to preferr to ignore this bug :( Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and but NOT for RPMS. But those warnings are ignored. + source files match upstream. 66578c2ffaebbe035a0735e65ad71c3f Gnome2-Print-1.000.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + .pc file present. + no -devel subpackage exists + no .la files. + no translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Followed perl packaging guidelines. APPROVED. Don't Forget to CLOSE this with NEXTRELEASE Imported and building for devel; branches requested for FC5,6. Thanks for the review! :) |