Bug 2168116

Summary: [MT2910] XML error: Invalid value for attribute 'speed' in element 'link': '(null)'.
Product: Red Hat Enterprise Linux 8 Reporter: Michal Privoznik <mprivozn>
Component: libvirtAssignee: Michal Privoznik <mprivozn>
Status: CLOSED ERRATA QA Contact: yalzhang <yalzhang>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.8CC: chayang, gveitmic, jdenemar, jsuchane, lmen, mprivozn, virt-maint, xuzhang, yalzhang, yanghliu, ymankad
Target Milestone: rcKeywords: Triaged, Upstream, ZStream
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-8.0.0-17.module+el8.8.0+18133+90800a0a Doc Type: Bug Fix
Doc Text:
Cause: PCIe specs addded new link speeds (32 and 64 GT/s). Consequence: Libvirt formatted incorrect node-device XML. Fix: New speeds added to libvirt's internal enum. Result: Libvirt formats node-device XML correctly.
Story Points: ---
Clone Of: 2105231
: 2170233 2170234 (view as bug list) Environment:
Last Closed: 2023-05-16 08:18:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2170233, 2170234    

Comment 5 yalzhang@redhat.com 2023-02-13 03:31:29 UTC
Reproduce this bug on libvirt-8.0.0-15.module+el8.8.0+18023+bf5b754e.x86_64;
Test on libvirt-8.0.0-17.module+el8.8.0+18133+90800a0a.x86_64, the bug is fixed:

# virsh nodedev-dumpxml pci_0000_17_00_0
<device>
  <name>pci_0000_17_00_0</name>
  <path>/sys/devices/pci0000:16/0000:16:02.0/0000:17:00.0</path>
  <parent>pci_0000_16_02_0</parent>
  <driver>
    <name>mlx5_core</name>
  </driver>
  <capability type='pci'>
    <class>0x020000</class>
    <domain>0</domain>
    <bus>23</bus>
    <slot>0</slot>
    <function>0</function>
    <product id='0x1021'>MT2910 Family [ConnectX-7]</product>
    <vendor id='0x15b3'>Mellanox Technologies</vendor>
    <capability type='virt_functions' maxCount='8'/>
    <capability type='vpd'>
      <name>NVIDIA ConnectX-7 Ethernet adapter card, 200 GbE , Dual-port QSFP, PCIe 5.0 x16, Crypto and Secure Boot</name>
      <fields access='readonly'>
        <change_level>A1</change_level>
        <part_number>MCX713106AC-VEAT</part_number>
        <serial_number>MT2215X06627</serial_number>
        <vendor_field index='2'>MCX713106AC-VEAT</vendor_field>
        <vendor_field index='3'>dc0a090053baec1180001070fda37b00</vendor_field>
        <vendor_field index='A'>MLX:MN=MLNX:CSKU=V2:UUID=V3:PCI=V0:MODL=CX713106A</vendor_field>
        <vendor_field index='0'>PCIeGen5 x16</vendor_field>
        <vendor_field index='U'>MT2215X06627MLNXS0D0F0</vendor_field>
      </fields>
    </capability>
    <iommuGroup number='20'>
      <address domain='0x0000' bus='0x17' slot='0x00' function='0x0'/>
    </iommuGroup>
    <numa node='0'/>
    <pci-express>
      <link validity='cap' port='0' speed='32' width='16'/>
      <link validity='sta' speed='16' width='16'/>
    </pci-express>
  </capability>
</device>

# lspci -vvv -s 17:00.0
...
	Capabilities: [60] Express (v2) Endpoint, MSI 00
		DevCap:	MaxPayload 512 bytes, PhantFunc 0, Latency L0s unlimited, L1 unlimited
			ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset+ SlotPowerLimit 75.000W
		DevCtl:	CorrErr- NonFatalErr+ FatalErr+ UnsupReq+
			RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+ FLReset-
			MaxPayload 512 bytes, MaxReadReq 4096 bytes
		DevSta:	CorrErr+ NonFatalErr- FatalErr- UnsupReq+ AuxPwr- TransPend-
		LnkCap:	Port #0, Speed 32GT/s, Width x16, ASPM not supported
			ClockPM- Surprise- LLActRep- BwNot- ASPMOptComp+
		LnkCtl:	ASPM Disabled; RCB 64 bytes, Disabled- CommClk+
			ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
		LnkSta:	Speed 16GT/s (downgraded), Width x16 (ok)
			TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
...

Comment 8 yalzhang@redhat.com 2023-02-15 10:03:23 UTC
verify the bug per comment 5

Comment 13 errata-xmlrpc 2023-05-16 08:18:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: virt:rhel and virt-devel:rhel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:2757