Bug 2168154

Summary: python-yara: relies on implicit function declarations due to python3-setuptools usage
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: python-yaraAssignee: Ali Erdinc Koroglu <aekoroglu>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: aekoroglu, mikel, rebus
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-setuptools-67.6.1-1.fc39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-04-21 09:21:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2153037    
Bug Blocks: 2137512    

Description Florian Weimer 2023-02-08 10:23:03 UTC
The setup.py file contains this:

def has_function(function_name, include_dirs=None, libraries=None, library_dirs=None):
  """Checks if a given functions exists in the current platform."""
  compiler = distutils.ccompiler.new_compiler()
  with muted(sys.stdout, sys.stderr):
      result = compiler.has_function(
          function_name,
          include_dirs=include_dirs,
          libraries=libraries,
          library_dirs=library_dirs)
  if os.path.exists('a.out'):
    os.remove('a.out')
  return result

And with the current Fedora version of python3-setuptools, this triggers an implicit function declaration for memmem:

    if has_function('memmem'):
      module.define_macros.append(('HAVE_MEMMEM', '1'))

(And for strlcpy, strlcat as well, but those are fine because we do not actually implement them.)

I hope we can patch python3-setuptools soon, so that we do not need to workaround this in python-yara.

Comment 1 Florian Weimer 2023-04-21 09:21:41 UTC
Verified as fixed via bug 2153037.