Bug 2168538

Summary: Review Request: minidlna - Lightweight DLNA/UPnP-AV server targeted at embedded systems
Product: [Fedora] Fedora Reporter: Dominik 'Rathann' Mierzejewski <dominik>
Component: Package ReviewAssignee: Benson Muite <benson_muite>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: benson_muite, ngompa13, package-review, rpm, zonexpertconsulting
Target Milestone: ---Flags: benson_muite: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://sourceforge.net/projects/minidlna/
Whiteboard:
Fixed In Version: minidlna-1.3.3-3.fc39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-23 01:56:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2218117    
Attachments:
Description Flags
The .spec file difference from Copr build 5528322 to 5615128
none
The .spec file difference from Copr build 5615128 to 5726093
none
The .spec file difference from Copr build 5726093 to 6140215
none
The .spec file difference from Copr build 6140215 to 6143079 none

Description Dominik 'Rathann' Mierzejewski 2023-02-09 11:01:17 UTC 
Spec URL: https://rathann.fedorapeople.org/review/minidlna/minidlna.spec
SRPM URL: https://rathann.fedorapeople.org/review/minidlna/minidlna-1.3.2-2.fc38.src.rpm
Description: 
MiniDLNA (aka ReadyDLNA) is server software with the aim of being fully
compliant with DLNA/UPnP-AV clients.

The minidlna daemon serves media files (music, pictures, and video) to
clients on your network.  Example clients include applications such as
Totem and XBMC, and devices such as portable media players, smartphones,
and televisions.

Fedora Account System Username: rathann
Comment 1 Benson Muite 2023-02-15 09:15:24 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[?]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2", "FSF All Permissive License", "BSD 3-Clause License", "*No
     copyright* GNU Library General Public License v2 or later [obsolete
     FSF postal address (Temple Place)]", "GNU Library General Public
     License v2 or later [generated file, obsolete FSF postal address
     (Temple Place)]", "FSF Unlimited License (with License Retention)
     [generated file]", "GNU General Public License v2.0 or later
     [generated file]", "GNU General Public License v3.0 or later", "FSF
     Unlimited License (with License Retention)", "FSF Unlimited License
     [generated file]", "X11 License [generated file]", "BSD 2-Clause
     License", "GNU General Public License v2.0 or later", "BSD 3-Clause
     License GNU General Public License, Version 2", "[generated file]",
     "*No copyright* [generated file]", "FSF Unlimited License (with
     License Retention) GNU Lesser General Public License GNU General
     Public License". 45 files have unknown license. Detailed output of
     licensecheck in
     /home/FedoraPackaging/reviews/minidlna/2168538-minidlna/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
     systemd_postun in %postun for Systemd service files.
     Note: Systemd service file(s) in minidlna
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: minidlna-1.3.2-2.fc38.x86_64.rpm
          minidlna-debuginfo-1.3.2-2.fc38.x86_64.rpm
          minidlna-debugsource-1.3.2-2.fc38.x86_64.rpm
          minidlna-1.3.2-2.fc38.src.rpm
================================= rpmlint session starts =================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpdo0rzrd_')]
checks: 31, packages: 4

minidlna.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/minidlna.conf
minidlna.x86_64: W: non-standard-uid /etc/minidlna.conf minidlna
minidlna.x86_64: W: non-standard-uid /run/minidlna minidlna
minidlna.x86_64: W: non-standard-uid /var/cache/minidlna minidlna
minidlna.x86_64: W: non-standard-uid /var/log/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /etc/minidlna.conf minidlna
minidlna.x86_64: W: non-standard-gid /run/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /var/cache/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /var/log/minidlna minidlna
minidlna.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/minidlnad
minidlna.x86_64: W: log-files-without-logrotate ['/var/log/minidlna']
= 4 packages and 0 specfiles checked; 1 errors, 10 warnings, 1 badness; has taken 4.6 s ==




Rpmlint (debuginfo)
-------------------
Checking: minidlna-debuginfo-1.3.2-2.fc38.x86_64.rpm
================================= rpmlint session starts =================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp5yxavi1i')]
checks: 31, packages: 1

== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.9 s ==





Rpmlint (installed packages)
----------------------------
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3

minidlna.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/minidlna.conf
minidlna.x86_64: W: non-standard-uid /etc/minidlna.conf minidlna
minidlna.x86_64: W: non-standard-uid /run/minidlna minidlna
minidlna.x86_64: W: non-standard-uid /var/cache/minidlna minidlna
minidlna.x86_64: W: non-standard-uid /var/log/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /etc/minidlna.conf minidlna
minidlna.x86_64: W: non-standard-gid /run/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /var/cache/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /var/log/minidlna minidlna
minidlna.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/minidlnad
minidlna.x86_64: W: log-files-without-logrotate ['/var/log/minidlna']
 3 packages and 0 specfiles checked; 1 errors, 10 warnings, 1 badness; has taken 7.4 s 



Source checksums
----------------
http://downloads.sourceforge.net/minidlna/1.3.2/minidlna-1.3.2.tar.gz :
  CHECKSUM(SHA256) this package     : 222ce45a1a60c3ce3de17527955d38e5ff7a4592d61db39577e6bf88e0ae1cb0
  CHECKSUM(SHA256) upstream package : 222ce45a1a60c3ce3de17527955d38e5ff7a4592d61db39577e6bf88e0ae1cb0


Requires
--------
minidlna (rpmlib, GLIBC filtered):
    /bin/sh
    config(minidlna)
    libFLAC.so.12()(64bit)
    libavahi-client.so.3()(64bit)
    libavahi-common.so.3()(64bit)
    libavformat.so.59()(64bit)
    libavformat.so.59(LIBAVFORMAT_59)(64bit)
    libavutil.so.57()(64bit)
    libavutil.so.57(LIBAVUTIL_57)(64bit)
    libc.so.6()(64bit)
    libexif.so.12()(64bit)
    libid3tag.so.0()(64bit)
    libjpeg.so.62()(64bit)
    libjpeg.so.62(LIBJPEG_6.2)(64bit)
    libogg.so.0()(64bit)
    libsqlite3.so.0()(64bit)
    libvorbis.so.0()(64bit)
    rtld(GNU_HASH)
    shadow-utils
    systemd

minidlna-debuginfo (rpmlib, GLIBC filtered):

minidlna-debugsource (rpmlib, GLIBC filtered):



Provides
--------
minidlna:
    config(minidlna)
    minidlna
    minidlna(x86-64)

minidlna-debuginfo:
    debuginfo(build-id)
    minidlna-debuginfo
    minidlna-debuginfo(x86-64)

minidlna-debugsource:
    minidlna-debugsource
    minidlna-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2168538
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, C/C++
Disabled plugins: Haskell, Ruby, R, Perl, PHP, SugarActivity, Java, fonts, Python, Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comments:
a) Upstream project has been renamed to ReadyMedia. Should this be renamed?
b) Should GPL-2.0-only also be added to the license section?
c) Can you add a license breakdown in the spec:
BSD 2-Clause License
--------------------
minidlna-1.3.2/kqueue.c
minidlna-1.3.2/monitor_kqueue.c
minidlna-1.3.2/select.c

BSD 3-Clause License
--------------------
minidlna-1.3.2/LICENCE.miniupnpd
minidlna-1.3.2/getifaddr.c
minidlna-1.3.2/getifaddr.h
minidlna-1.3.2/minidlnapath.h
minidlna-1.3.2/minidlnatypes.h
minidlna-1.3.2/minissdp.c
minidlna-1.3.2/minissdp.h
minidlna-1.3.2/minixml.c
minidlna-1.3.2/minixml.h
minidlna-1.3.2/options.c
minidlna-1.3.2/options.h
minidlna-1.3.2/process.c
minidlna-1.3.2/process.h
minidlna-1.3.2/testupnpdescgen.c
minidlna-1.3.2/upnpdescgen.c
minidlna-1.3.2/upnpdescgen.h
minidlna-1.3.2/upnpreplyparse.c
minidlna-1.3.2/upnpreplyparse.h

BSD 3-Clause License GNU General Public License, Version 2
----------------------------------------------------------
minidlna-1.3.2/minidlna.c
minidlna-1.3.2/upnpevents.c
minidlna-1.3.2/upnpevents.h
minidlna-1.3.2/upnpglobalvars.c
minidlna-1.3.2/upnpglobalvars.h
minidlna-1.3.2/upnphttp.c
minidlna-1.3.2/upnphttp.h
minidlna-1.3.2/upnpsoap.c

GNU General Public License, Version 2
-------------------------------------
minidlna-1.3.2/COPYING
minidlna-1.3.2/albumart.c
minidlna-1.3.2/albumart.h
minidlna-1.3.2/avahi.c
minidlna-1.3.2/clients.c
minidlna-1.3.2/clients.h
minidlna-1.3.2/containers.c
minidlna-1.3.2/containers.h
minidlna-1.3.2/icons.c
minidlna-1.3.2/image_utils.c
minidlna-1.3.2/image_utils.h
minidlna-1.3.2/libav.h
minidlna-1.3.2/metadata.c
minidlna-1.3.2/metadata.h
minidlna-1.3.2/monitor.c
minidlna-1.3.2/monitor_inotify.c
minidlna-1.3.2/playlist.c
minidlna-1.3.2/playlist.h
minidlna-1.3.2/po/de.po
minidlna-1.3.2/po/minidlna.pot
minidlna-1.3.2/po/pl.po
minidlna-1.3.2/po/ru.po
minidlna-1.3.2/po/sl.po
minidlna-1.3.2/scanner.c
minidlna-1.3.2/scanner.h
minidlna-1.3.2/scanner_sqlite.h
minidlna-1.3.2/sendfile.h
minidlna-1.3.2/sql.c
minidlna-1.3.2/sql.h
minidlna-1.3.2/tivo_beacon.h
minidlna-1.3.2/tivo_commands.c
minidlna-1.3.2/tivo_commands.h
minidlna-1.3.2/tivo_utils.c
minidlna-1.3.2/tivo_utils.h
minidlna-1.3.2/upnpsoap.h
minidlna-1.3.2/utils.c
minidlna-1.3.2/utils.h
minidlna-1.3.2/uuid.c
minidlna-1.3.2/uuid.h
Comment 2 Dominik 'Rathann' Mierzejewski 2023-02-15 10:46:18 UTC 
Thanks for the review!

(In reply to Benson Muite from comment #1)
[...] 
> Comments:
> a) Upstream project has been renamed to ReadyMedia. Should this be renamed?

No. Upstream project is ReadyMedia but even they distribute minidlna as minidlna.

> b) Should GPL-2.0-only also be added to the license section?

Yes.

> c) Can you add a license breakdown in the spec:

Yes, but in a separate file. I don't want to clutter the spec.

Spec URL: https://rathann.fedorapeople.org/review/minidlna/minidlna.spec
SRPM URL: https://rathann.fedorapeople.org/review/minidlna/minidlna-1.3.2-3.fc38.src.rpm

* Wed Feb 15 2023 Dominik Mierzejewski <dominik> - 1.3.2-3
- add missing GPLv2 only to license field
- add licensing breakdown
Comment 3 Jakub Kadlčík 2023-02-15 10:59:33 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5528322
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168538-minidlna/fedora-rawhide-x86_64/05528322-minidlna/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 4 Benson Muite 2023-02-22 11:24:06 UTC 
Thanks. Fedora review has a number of warnings:


minidlna.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/minidlna.conf
minidlna.x86_64: W: non-standard-uid /etc/minidlna.conf minidlna
minidlna.x86_64: W: non-standard-uid /run/minidlna minidlna
minidlna.x86_64: W: non-standard-uid /var/cache/minidlna minidlna
minidlna.x86_64: W: non-standard-uid /var/log/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /etc/minidlna.conf minidlna
minidlna.x86_64: W: non-standard-gid /run/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /var/cache/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /var/log/minidlna minidlna
minidlna.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/minidlnad
minidlna.x86_64: W: log-files-without-logrotate ['/var/log/minidlna']
Comment 5 Dominik 'Rathann' Mierzejewski 2023-02-22 16:04:35 UTC 
(In reply to Benson Muite from comment #4)
> Thanks. Fedora review has a number of warnings:
> 
> 
> minidlna.x86_64: W: post-without-tmpfile-creation
> /usr/lib/tmpfiles.d/minidlna.conf

Not sure what this means. https://docs.fedoraproject.org/en-US/packaging-guidelines/Tmpfiles.d/ make no mention of %post.

> minidlna.x86_64: W: non-standard-uid /etc/minidlna.conf minidlna
> minidlna.x86_64: W: non-standard-uid /run/minidlna minidlna
> minidlna.x86_64: W: non-standard-uid /var/cache/minidlna minidlna
> minidlna.x86_64: W: non-standard-uid /var/log/minidlna minidlna
> minidlna.x86_64: W: non-standard-gid /etc/minidlna.conf minidlna
> minidlna.x86_64: W: non-standard-gid /run/minidlna minidlna
> minidlna.x86_64: W: non-standard-gid /var/cache/minidlna minidlna
> minidlna.x86_64: W: non-standard-gid /var/log/minidlna minidlna

This is expected, minidlna has it's own user and group.

> minidlna.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/minidlnad

This doesn't seem to be an issue in practice, minidlnad is started as minidlna user by the systemd service.
It's not intended to be executed by root. But sure, I can probably fix that for correctness sake.

> minidlna.x86_64: W: log-files-without-logrotate ['/var/log/minidlna']

minidlna doesn't produce any log files during regular operation with default config.
I guess one might add log rotation configuration in case someone enables debug logging.

Do any of these affect acceptability of the package in Fedora or can I fix them later?
Comment 6 Andrew Bauer 2023-02-23 13:27:14 UTC 
(In reply to Dominik 'Rathann' Mierzejewski from comment #5)
> (In reply to Benson Muite from comment #4)
> > Thanks. Fedora review has a number of warnings:
> > 
> > 
> > minidlna.x86_64: W: post-without-tmpfile-creation
> > /usr/lib/tmpfiles.d/minidlna.conf
> 
> Not sure what this means.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Tmpfiles.d/ make
> no mention of %post.
> 

Just add %tmpfiles_create macro to %post

$ rpmlint -e post-without-tmpfile-creation
post-without-tmpfile-creation:
Please use the %tmpfiles_create macro in %post for each of your tmpfiles.d
files if you expect this file or directory to be available after package
installation (and before reboot).
Comment 7 Dominik 'Rathann' Mierzejewski 2023-03-08 14:30:19 UTC 
Spec URL: https://rathann.fedorapeople.org/review/minidlna/minidlna.spec
SRPM URL: https://rathann.fedorapeople.org/review/minidlna/minidlna-1.3.2-4.fc38.src.rpm

* Tue Feb 28 2023 Dominik Mierzejewski <dominik> - 1.3.2-4
- call tmpfiles_create macro to create /run/minidlna after installation
- add logrotate config drop-in based on Debian

I'm not sure how to fix the E: missing-call-to-setgroups-before-setuid issue, so I'll contact upstream about it.

Anything else?
Comment 8 Jakub Kadlčík 2023-03-08 14:50:11 UTC 
Created attachment 1949060 [details]
The .spec file difference from Copr build 5528322 to 5615128
Comment 9 Jakub Kadlčík 2023-03-08 14:50:13 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5615128
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168538-minidlna/fedora-rawhide-x86_64/05615128-minidlna/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 10 Benson Muite 2023-03-14 04:38:28 UTC 
Sorry for the delay. Checking this.
Comment 11 Benson Muite 2023-03-19 11:39:30 UTC 
$ rpmlint -e missing-call-to-setgroups-before-setuid
missing-call-to-setgroups-before-setuid:
This executable is calling setuid and setgid without setgroups or initgroups.
This means it didn't relinquish all groups, and this would be a potential
security issue.


Maybe the file minidlna.c should be modified? It uses setgid and setuid but
does not get all the associated group ids see

https://www.gnu.org/software/libc/manual/html_node/Setting-Groups.html

$ rpmlint -e non-standard-uid
non-standard-uid:
A file in this package is owned by an unregistered user id. To register the
user, please make a pull request to the rpmlint config file
configs/Fedora/fedora.toml in the rpmlint repository.

$ rpmlint -e non-standard-gid
non-standard-gid:
A file in this package is owned by an unregistered group id. To register the
group, please make a pull request to the rpmlint config file
configs/Fedora/fedora.toml in the rpmlint repository.

Not clear what to change at:
https://github.com/rpm-software-management/rpmlint/blob/main/configs/Fedora/fedora.toml

Should minidlna have a directory instead of dev/null ?
useradd -r -g minidlna -d /dev/null 

Might it be possible to use dynamic allocation:
https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/#_dynamic_allocation

Nginx recommends logrotate:
https://src.fedoraproject.org/rpms/nginx/blob/rawhide/f/nginx.spec
Comment 12 Benson Muite 2023-03-19 12:17:50 UTC 
It seems to install and run ok with the default settings, though have not tested
extensively.

Should the description have "on your local network" instead of "on your network"?
Comment 13 Neal Gompa 2023-03-19 13:48:36 UTC 
> # Edit the default config file
> sed -i 's/#log_dir=\/var\/log/#log_dir=\/var\/log\/minidlna/' \
>   %{name}.conf

To make this easier to read, you should consider changing the substitution delimiter, like so:

sed -i 's|#log_dir=/var/log|#log_dir=/var/log/minidlna|' %{name}.conf

> %pre
> getent group minidlna >/dev/null || groupadd -r minidlna
> getent passwd minidlna >/dev/null || \
> useradd -r -g minidlna -d /dev/null -s /sbin/nologin \
>   -c "minidlna service account" minidlna
> exit 0

System users need to use the sysusers.d format: https://fedoraproject.org/wiki/Changes/Adopting_sysusers.d_format

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/#_dynamic_allocation
Comment 14 Dominik 'Rathann' Mierzejewski 2023-03-29 10:40:50 UTC 
Spec URL: https://rathann.fedorapeople.org/review/minidlna/minidlna.spec
SRPM URL: https://rathann.fedorapeople.org/review/minidlna/minidlna-1.3.2-5.fc39.src.rpm

* Wed Mar 29 2023 Dominik Mierzejewski <dominik> - 1.3.2-5
- use sysusers.d to pre-create system user account
- make the sed expression easier to read
- adjust description
Comment 15 Jakub Kadlčík 2023-03-29 10:51:44 UTC 
Created attachment 1954383 [details]
The .spec file difference from Copr build 5615128 to 5726093
Comment 16 Jakub Kadlčík 2023-03-29 10:51:46 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5726093
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168538-minidlna/fedora-rawhide-x86_64/05726093-minidlna/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 17 Dominik 'Rathann' Mierzejewski 2023-06-29 11:09:06 UTC 
Benson, is this ready to be approved?
Comment 18 Dominik 'Rathann' Mierzejewski 2023-07-04 09:28:46 UTC 
Spec URL: https://rathann.fedorapeople.org/review/minidlna/minidlna.spec
SRPM URL: https://rathann.fedorapeople.org/review/minidlna/minidlna-1.3.3-1.fc39.src.rpm

* Tue Jul 04 2023 Dominik Mierzejewski <dominik> - 1.3.3-1
- update to 1.3.3
Comment 19 Fedora Review Service 2023-07-04 09:34:29 UTC 
Created attachment 1973966 [details]
The .spec file difference from Copr build 5726093 to 6140215
Comment 20 Fedora Review Service 2023-07-04 09:34:31 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6140215
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168538-minidlna/fedora-rawhide-x86_64/06140215-minidlna/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 21 Benson Muite 2023-07-05 05:39:02 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2", "FSF All Permissive License", "BSD 3-Clause License", "*No
     copyright* GNU Library General Public License v2 or later [obsolete
     FSF postal address (Temple Place)]", "GNU Library General Public
     License v2 or later [generated file, obsolete FSF postal address
     (Temple Place)]", "FSF Unlimited License (with License Retention)
     [generated file]", "GNU General Public License v2.0 or later
     [generated file]", "GNU General Public License v3.0 or later", "FSF
     Unlimited License (with License Retention)", "FSF Unlimited License
     [generated file]", "X11 License [generated file]", "BSD 2-Clause
     License", "GNU General Public License v2.0 or later", "BSD 3-Clause
     License GNU General Public License, Version 2", "[generated file]",
     "*No copyright* [generated file]", "FSF Unlimited License (with
     License Retention) GNU Lesser General Public License GNU General
     Public License". 45 files have unknown license. Detailed output of
     licensecheck in
     /home/FedoraPackaging/reviews/minidlna/2168538-minidlna/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /etc/logrotate.d(bes, samba-
     common, psad, sssd-common, wpa_supplicant, below, macromilter,
     lightdm, yast2-filesystem, ppp, cepces, copr-dist-git, gerbera, kdm-
     settings, proftpd, logrotate, retrace-server, ntpsec, openqa)
[x]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
     systemd_postun in %postun for Systemd service files.
     Note: Systemd service file(s) in minidlna
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: minidlna-1.3.3-1.fc38.x86_64.rpm
          minidlna-debuginfo-1.3.3-1.fc38.x86_64.rpm
          minidlna-debugsource-1.3.3-1.fc38.x86_64.rpm
          minidlna-1.3.3-1.fc38.src.rpm
==================================================== rpmlint session starts ====================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpmhcrxfq2')]
checks: 31, packages: 4

minidlna.x86_64: W: non-standard-uid /etc/minidlna.conf minidlna
minidlna.x86_64: W: non-standard-uid /run/minidlna minidlna
minidlna.x86_64: W: non-standard-uid /var/cache/minidlna minidlna
minidlna.x86_64: W: non-standard-uid /var/log/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /etc/minidlna.conf minidlna
minidlna.x86_64: W: non-standard-gid /run/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /var/cache/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /var/log/minidlna minidlna
minidlna.x86_64: E: missing-dependency-to-logrotate for logrotate script /etc/logrotate.d/minidlna
minidlna.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/minidlnad
===================== 4 packages and 0 specfiles checked; 2 errors, 8 warnings, 2 badness; has taken 3.7 s =====================




Rpmlint (debuginfo)
-------------------
Checking: minidlna-debuginfo-1.3.3-1.fc38.x86_64.rpm
==================================================== rpmlint session starts ====================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpe20fb8o3')]
checks: 31, packages: 1

===================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.5 s =====================





Rpmlint (installed packages)
----------------------------
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3

minidlna.x86_64: W: non-standard-uid /etc/minidlna.conf minidlna
minidlna.x86_64: W: non-standard-uid /run/minidlna minidlna
minidlna.x86_64: W: non-standard-uid /var/cache/minidlna minidlna
minidlna.x86_64: W: non-standard-uid /var/log/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /etc/minidlna.conf minidlna
minidlna.x86_64: W: non-standard-gid /run/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /var/cache/minidlna minidlna
minidlna.x86_64: W: non-standard-gid /var/log/minidlna minidlna
minidlna.x86_64: E: missing-dependency-to-logrotate for logrotate script /etc/logrotate.d/minidlna
minidlna.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/minidlnad
 3 packages and 0 specfiles checked; 2 errors, 8 warnings, 2 badness; has taken 7.1 s 



Source checksums
----------------
http://downloads.sourceforge.net/minidlna/1.3.3/minidlna-1.3.3.tar.gz :
  CHECKSUM(SHA256) this package     : 39026c6d4a139b9180192d1c37225aa3376fdf4f1a74d7debbdbb693d996afa4
  CHECKSUM(SHA256) upstream package : 39026c6d4a139b9180192d1c37225aa3376fdf4f1a74d7debbdbb693d996afa4


Requires
--------
minidlna (rpmlib, GLIBC filtered):
    /bin/sh
    config(minidlna)
    libFLAC.so.12()(64bit)
    libavahi-client.so.3()(64bit)
    libavahi-common.so.3()(64bit)
    libavformat.so.60()(64bit)
    libavformat.so.60(LIBAVFORMAT_60)(64bit)
    libavutil.so.58()(64bit)
    libavutil.so.58(LIBAVUTIL_58)(64bit)
    libc.so.6()(64bit)
    libexif.so.12()(64bit)
    libid3tag.so.0()(64bit)
    libjpeg.so.62()(64bit)
    libjpeg.so.62(LIBJPEG_6.2)(64bit)
    libogg.so.0()(64bit)
    libsqlite3.so.0()(64bit)
    libvorbis.so.0()(64bit)
    rtld(GNU_HASH)
    shadow-utils
    systemd

minidlna-debuginfo (rpmlib, GLIBC filtered):

minidlna-debugsource (rpmlib, GLIBC filtered):



Provides
--------
minidlna:
    config(minidlna)
    group(minidlna)
    minidlna
    minidlna(x86-64)
    user(minidlna)

minidlna-debuginfo:
    debuginfo(build-id)
    minidlna-debuginfo
    minidlna-debuginfo(x86-64)

minidlna-debugsource:
    minidlna-debugsource
    minidlna-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2168538 -m fedora-38-x86_64
Buildroot used: fedora-38-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Ocaml, Java, Python, Haskell, R, SugarActivity, Perl, fonts, PHP, Ruby
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comments:
a) Any response from upstream on "E: missing-call-to-setgroups-before-setuid" ?
tried using setreuid and setregid instead, error message no longer appears
https://download.copr.fedorainfracloud.org/results/fed500/minidlna/fedora-38-aarch64/06142705-minidlna/fedora-review/review.txt
https://security.stackexchange.com/questions/122141/always-setgroups-before-setuid
https://www.oreilly.com/library/view/secure-programming-cookbook/0596003943/ch01s03.html
https://wiki.sei.cmu.edu/confluence/display/c/POS36-C.+Observe+correct+revocation+order+while+relinquishing+privileges
From https://www.ibm.com/docs/en/aix/7.2?topic=s-setuid-setruid-seteuid-setreuid-setuidx-subroutine
Perhaps check with upstream if this is ok

b) Builds on all architectures
https://copr.fedorainfracloud.org/coprs/fed500/minidlna/build/6142608/
Comment 22 Dominik 'Rathann' Mierzejewski 2023-07-05 10:05:16 UTC 
(In reply to Benson Muite from comment #21)
> Package Review

Thanks!

[...]
> Comments:
> a) Any response from upstream on "E:
> missing-call-to-setgroups-before-setuid" ?
> tried using setreuid and setregid instead, error message no longer appears

But that has a diifferent effect and is probably not what upstream meant here.

[...]
> Perhaps check with upstream if this is ok

I reported the issue upstream:
https://sourceforge.net/p/minidlna/bugs/356/

Is there anything else or can this package be approved?

Spec URL: https://rathann.fedorapeople.org/review/minidlna/minidlna.spec
SRPM URL: https://rathann.fedorapeople.org/review/minidlna/minidlna-1.3.3-2.fc39.src.rpm

* Wed Jul 05 2023 Dominik Mierzejewski <dominik> - 1.3.3-2
- fix missing-call-to-setgroups-before-setuid rpmlint error
- add weak dependency on logrotate
Comment 23 Fedora Review Service 2023-07-05 10:12:28 UTC 
Created attachment 1974077 [details]
The .spec file difference from Copr build 6140215 to 6143079
Comment 24 Fedora Review Service 2023-07-05 10:12:30 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6143079
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168538-minidlna/fedora-rawhide-x86_64/06143079-minidlna/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 25 Benson Muite 2023-07-07 17:10:58 UTC 
Thanks. Seems ok. Approved.
Comment 26 Fedora Admin user for bugzilla script actions 2023-07-07 17:44:54 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/minidlna
Comment 27 Benson Muite 2023-07-08 03:49:08 UTC 
Review of https://bugzilla.redhat.com/show_bug.cgi?id=2219371 would be
appreciated if time and expertise allows.