Bug 2168579

Summary: Rebase SBD on upstream 1.5.2 for RHEL 9.3
Product: Red Hat Enterprise Linux 9 Reporter: Klaus Wenninger <kwenning>
Component: sbdAssignee: Klaus Wenninger <kwenning>
Status: VERIFIED --- QA Contact: cluster-qe <cluster-qe>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.3CC: cluster-maint, mmazoure
Target Milestone: rcKeywords: Rebase, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: sbd-1.5.2-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2168567 Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2168567    
Bug Blocks:    

Description Klaus Wenninger 2023-02-09 12:45:26 UTC
+++ This bug was initially created as a clone of Bug #2168567 +++

Description of problem:


Changes since 1.5.1:

- fail startup if pacemaker integration is disabled while
  SBD_SYNC_RESOURCE_STARTUP is conflicting (+ hint to overcome)
- improve logs
  - when logging state of SBD_PACEMAKER tell it is just that as
    this might still be overridden via cmdline options
  - log a warning if SBD_PACEMAKER is overridden by -P or -PP option
  - do not warn about startup syncing with pacemaker integration disabled
  - when watchdog-device is busy give a hint on who is hogging it
- improve build environment
  - have --with-runstatedir overrule --runstatedir
  - use new package name for pacemaker devel on opensuse
  - make config location configurable for man-page-creation
  - reverse alloc/de-alloc order to make gcc-12 static analysis happy
- improve test environment
  - have image-files in /dev/shm to assure they are in memory and
    sbd opening the files with O_SYNC doesn't trigger unnecessary
    syncs on a heavily loaded test-machine
    fallback to /tmp if /dev/shm doesn't exist
  - wrapping away libaio and usage of device-mapper for block-device
    simulation can now be passed into make via
    SBD_USE_DM & SBD_TRANSLATE_AIO
  - have variables that configure test-environment be printed
    out prior to running tests
  - finally assure we clean environment when interrupted by a
    signal (bash should have done it with just setting EXIT handler -
    but avoiding bashism might come handy one day)


Only thing of the above that has been part of RHEL up to now as a
patch on top of 1.5.1 is giving a hint on who is hogging a watchdog-device.