Bug 2168728

Summary: Uploading invalid datastream file while creating Tailoring File in Satellite WebUI should show some meaningful error message instead of 500 Internal Server Error
Product: Red Hat Satellite Reporter: Jayant Bhatia <jbhatia>
Component: SCAP PluginAssignee: Adam Ruzicka <aruzicka>
Status: CLOSED ERRATA QA Contact: Pavel Novotny <pnovotny>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.13.0CC: aruzicka, lstejska, mhulan, pcreech, rlavi
Target Milestone: 6.15.0Keywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-foreman_openscap-7.1.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-04-23 17:13:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
better error message for invalid tailoring file none

Description Jayant Bhatia 2023-02-09 21:17:43 UTC
Description of problem:

The tailoring file creation fails when a invalid datastream file is uploaded which is a expected behavior. But a relevant meaningful message should get displayed to user instead of '500 Internal Server Error'


Version-Release number of selected component (if applicable): satellite-6.13.0-4.el8sat.noarch


How reproducible: Always


Steps to Reproduce:

1. Navigate to Satellite WebUI -> Hosts -> Tailoring Files -> New Tailoring File.

2. Enter the name and then browse and upload DataStream tailoring file which is not valid. Select the respective Organizations and Locations.

3. Hit submit.


Actual results: The Tailoring file cannot be created and it fails with below message. (Refer attached screen image)

       Oops, we're sorry but something went wrong 500 Internal Server Error


Expected results: Some meaningful message like "Invalid Datastream tailoring file" should be shown on screen instead of failure with 500 Internal Server Error.


Additional info: Uploading valid datastream tailoring file leads to successful creation. It would be great if the datastream file is validated when it is browsed and uploaded and shows the relevant message then and there instead of waiting for user to hit Submit.

Comment 1 Jayant Bhatia 2023-02-09 21:22:15 UTC
Created attachment 1943175 [details]
Error Shown To user

Comment 3 Jayant Bhatia 2023-02-09 21:27:53 UTC
This behavior is also seen in Satellite 6.12.

Comment 5 Brad Buckingham 2023-10-30 11:29:29 UTC
Bulk setting Target Milestone = 6.15.0 where sat-6.15.0+ is set.

Comment 6 Pavel Novotny 2023-12-08 16:57:48 UTC
Verified in Sat 6.15 snap 2:
satellite-6.15.0-1.el8sat.noarch
rubygem-foreman_openscap-7.1.0-1.el8sat.noarch

When providing an invalid tailoring datastream file, the page no longer shows the infamous HTTP 500 page "Oops, we're sorry but something went wrong 500 Internal Server Error",
but shows more informative error message right next to the Scap File field, like "Error occurred: Failed to parse profiles". See the attached screenshot for details.

Comment 7 Pavel Novotny 2023-12-08 16:58:56 UTC
Created attachment 2003325 [details]
better error message for invalid tailoring file

Comment 10 errata-xmlrpc 2024-04-23 17:13:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.15.0 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:2010