Bug 2169238

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5520349
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169238-whatip/fedora-rawhide-x86_64/05520349-whatip/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Spec review:

> desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop
> appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/%{app_id}.appdata.xml

Nit: These should be in %check so that it's obvious they're part of package verification

> %{python3_sitelib}/%{name}

Please add a trailing slash so that it's obvious the RPM that this is a directory.

> %{_datadir}/icons/hicolor/*/*/%{app_id}*

This means we need "Requires: hicolor-icon-theme" in the package.

> %{_datadir}/%{name}

Please add a trailing slash so that it's obvious the RPM that this is a directory.

(In reply to Neal Gompa from comment #2)
> Nit: These should be in %check so that it's obvious they're part of package verification

The guidelines state either %check or %install without preference.

> Please add a trailing slash so that it's obvious the RPM that this is a directory.

I'm not against this, but this seems to be a style choice rather than a guidelines question.

> This means we need "Requires: hicolor-icon-theme" in the package.

Added.

Spec URL: https://yselkowitz.fedorapeople.org/whatip.spec
SRPM URL: https://yselkowitz.fedorapeople.org/whatip-1.1-1.fc39.src.rpm
Description: What IP displays information on your local network, IP addresses and open ports.
Fedora Account System Username: yselkowitz

Created attachment 1943870 [details]
The .spec file difference from Copr build 5520349 to 5522752

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5522752
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169238-whatip/fedora-rawhide-x86_64/05522752-whatip/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

(In reply to Yaakov Selkowitz from comment #3)
> (In reply to Neal Gompa from comment #2)
> > Nit: These should be in %check so that it's obvious they're part of package verification
> 
> The guidelines state either %check or %install without preference.
> 
> > Please add a trailing slash so that it's obvious the RPM that this is a directory.
> 
> I'm not against this, but this seems to be a style choice rather than a
> guidelines question.
> 

We really should add this to the guidelines, but the reason for this is to prevent accidental directory->file transitions, which can cause RPM upgrade failures.

(In reply to Neal Gompa from comment #7)
> We really should add this to the guidelines, but the reason for this is to
> prevent accidental directory->file transitions, which can cause RPM upgrade
> failures.

Generally speaking e.g. %{_datadir}/%{name} isn't about to become a file.  Any guidelines along these lines IMO should be limited in avoiding potential future collisions in specific known cases rather than dictating syntax/style.

In any case, I already added these in the previous update.

Everything looks good, then.

PACKAGE APPROVED.

The Pagure repository was created at https://src.fedoraproject.org/rpms/whatip

FEDORA-2023-b55f632014 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b55f632014

FEDORA-2023-b55f632014 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b55f632014 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b55f632014

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2023-b55f632014 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.