Bug 2169246
| Summary: | Review Request: bitstower-markets - A stock and currency tracker | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yaakov Selkowitz <yselkowi> | ||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/tomasz-oponowicz/markets | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-02-22 09:24:39 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Yaakov Selkowitz
2023-02-13 02:48:52 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5520620 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169246-bitstower-markets/fedora-rawhide-x86_64/05520620-bitstower-markets/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec review: > desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop > appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml Nit: These should be in %check so that it's obvious they're part of package verification > %{_datadir}/icons/hicolor/*/*/%{app_id}* This means we need "Requires: hicolor-icon-theme" in the package. (In reply to Neal Gompa from comment #2) > Nit: These should be in %check so that it's obvious they're part of package verification The guidelines state either %check or %install without preference. > This means we need "Requires: hicolor-icon-theme" in the package. Added. Spec URL: https://yselkowitz.fedorapeople.org/bitstower-markets.spec SRPM URL: https://yselkowitz.fedorapeople.org/bitstower-markets-0.5.4-1.fc39.src.rpm Description: The Markets application delivers financial data to your fingertips. Track stocks prices, currency exchange rates, and cryptocurrencies. Fedora Account System Username: yselkowitz Created attachment 1943866 [details]
The .spec file difference from Copr build 5520620 to 5522570
Copr build: https://copr.fedorainfracloud.org/coprs/build/5522570 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169246-bitstower-markets/fedora-rawhide-x86_64/05522570-bitstower-markets/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This looks good to me. PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/bitstower-markets FEDORA-EPEL-2023-6dca237fef has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-6dca237fef FEDORA-2023-4c8727a1bf has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4c8727a1bf FEDORA-2023-4c8727a1bf has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-4c8727a1bf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-4c8727a1bf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2023-6dca237fef has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-6dca237fef See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-FLATPAK-2023-a716f7de32 has been submitted as an update to Fedora 37 Flatpaks. https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2023-a716f7de32 FEDORA-FLATPAK-2023-a716f7de32 has been pushed to the Fedora 37 Flatpaks testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2023-a716f7de32 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2023-6dca237fef has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-4c8727a1bf has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-FLATPAK-2023-a716f7de32 has been pushed to the Fedora 37 Flatpaks stable repository. If problem still persists, please make note of it in this bug report. |