Bug 2169500

Summary: bletchmame FTBFS after F38 mass rebuild
Product: [Fedora] Fedora Reporter: Ondrej Mosnáček <omosnacek>
Component: bletchmameAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: bletchmame-2.15-5.fc39 bletchmame-2.15-5.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-03-25 18:39:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2117176, 2164261    

Description Ondrej Mosnáček 2023-02-13 18:54:46 UTC
https://koji.fedoraproject.org/koji/taskinfo?taskID=96313778

This blocks the update of quazip to 1.4, which will bump soname and will need a rebuild of all dependent packages (including bletchmame).

Comment 1 Ondrej Mosnáček 2023-03-24 19:13:55 UTC
This is still not resolved. Davide, could you please fix the build errors? I'd like to reiterate that this is blocking updating quazip to version 1.4.

FWIW, these are the errors I get from building the latest rawhide branch in mock:
```
/builddir/build/BUILD/bletchmame-2.15/src/hash.cpp: In static member function 'static std::optional<Hash> Hash::calculate(QIODevice&, const CalculateCallback&)':
/builddir/build/BUILD/bletchmame-2.15/src/hash.cpp:68:42: error: 'void QCryptographicHash::addData(const char*, qsizetype)' is deprecated: Use the QByteArrayView overload instead [-Werror=deprecated-declarations]
   68 |                 cryptographicHash.addData(buffer, len);
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
In file included from /usr/include/qt6/QtCore/QCryptographicHash:1,
                 from /builddir/build/BUILD/bletchmame-2.15/src/hash.cpp:13:
/usr/include/qt6/QtCore/qcryptographichash.h:73:10: note: declared here
   73 |     void addData(const char *data, qsizetype length);
      |          ^~~~~~~
cc1plus: all warnings being treated as errors
gmake[2]: *** [CMakeFiles/BletchMAME_core.dir/build.make:219: CMakeFiles/BletchMAME_core.dir/src/hash.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
/builddir/build/BUILD/bletchmame-2.15/src/iniparser.cpp: In member function 'bool IniFileParser::next(QString&, QString&)':
/builddir/build/BUILD/bletchmame-2.15/src/iniparser.cpp:28:9: error: invalid use of incomplete type 'class QString'
   28 |         name = "";
      |         ^~~~
In file included from /usr/include/qt6/QtCore/qiodevicebase.h:7,
                 from /usr/include/qt6/QtCore/qtextstream.h:7,
                 from /usr/include/qt6/QtCore/QTextStream:1,
                 from /builddir/build/BUILD/bletchmame-2.15/src/iniparser.h:12,
                 from /builddir/build/BUILD/bletchmame-2.15/src/iniparser.cpp:9:
/usr/include/qt6/QtCore/qglobal.h:947:7: note: forward declaration of 'class QString'
  947 | class QString;
      |       ^~~~~~~
/builddir/build/BUILD/bletchmame-2.15/src/iniparser.cpp:29:9: error: invalid use of incomplete type 'class QString'
   29 |         value = "";
      |         ^~~~~
/usr/include/qt6/QtCore/qglobal.h:947:7: note: forward declaration of 'class QString'
  947 | class QString;
      |       ^~~~~~~
/builddir/build/BUILD/bletchmame-2.15/src/iniparser.cpp:41:17: error: aggregate 'QString line' has incomplete type and cannot be defined
   41 |         QString line;
      |                 ^~~~
gmake[2]: *** [CMakeFiles/BletchMAME_core.dir/build.make:303: CMakeFiles/BletchMAME_core.dir/src/iniparser.cpp.o] Error 1
gmake[2]: Leaving directory '/builddir/build/BUILD/bletchmame-2.15/redhat-linux-build'
gmake[1]: *** [CMakeFiles/Makefile2:93: CMakeFiles/BletchMAME_core.dir/all] Error 2
gmake[1]: Leaving directory '/builddir/build/BUILD/bletchmame-2.15/redhat-linux-build'
gmake: *** [Makefile:149: all] Error 2
```

Comment 2 Davide Cavalca 2023-03-25 17:13:04 UTC
I'm taking a look now, sorry for missing this.

Comment 3 Fedora Update System 2023-03-25 18:35:55 UTC
FEDORA-2023-799d9a67e0 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-799d9a67e0

Comment 4 Fedora Update System 2023-03-25 18:39:02 UTC
FEDORA-2023-799d9a67e0 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Fedora Update System 2023-03-25 18:54:50 UTC
FEDORA-2023-37583bf06a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-37583bf06a

Comment 6 Fedora Update System 2023-03-26 03:34:37 UTC
FEDORA-2023-37583bf06a has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-37583bf06a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-04-03 00:16:02 UTC
FEDORA-2023-37583bf06a has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.