Bug 217052

Hi,

About a week ago I asked for easy to reproduce and potentially easy to fix bugs 
for my CS students (I'm a CS teacher) to work on. One of the bug reports which 
I received was this one (which wasn't in BZ yet, so I'm entering it now):

| -- CMakeLists.txt --
| include(foo.cmake)
| foo()
| 
| -- foo.cmake --
| macro(foo)
|         message(SEND_ERROR "foo")
| endmacro(foo)
|
| $ cmake CMakeLists.txt
| ...
| Segmentation fault (core dumped)

with Extra's cmake-2.4.3-3.fc5

I did not had time yet to test it with recent cmake version.

---

My student has taken a look at this and the problem is that when an error is 
thrown during execution, rather then during parsing as this code does, then the 
args vector which should contain the filename and lineno as args[0] is empty. 
This seems to be normal as the code just above the code causing the crash 
checks for an empty args vector.

This patch fixes this issue by using newLFF.Arguments[0] instead of args[0], as
newLFF.Arguments[0] gets filed in a code path which checks that args is not a 0 
sized vector and otherwise fills newLFF.Arguments[0] with a filename 
of "unknown" instead of crashing.

Also could you please send this upstream ?