Bug 2170682
| Summary: | Updates cause Xfce to lose all menu icons | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ian Laurie <nixuser> |
| Component: | xfce4-session | Assignee: | Mukundan Ragavan <nonamedotc> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 38 | CC: | awilliam, kevin, nonamedotc |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | AcceptedFreezeException | ||
| Fixed In Version: | xfce4-session-4.18.1-2.fc38 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-03-07 19:43:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2083911 | ||
|
Description
Ian Laurie
2023-02-16 22:17:46 UTC
A fresh Xfce install using Fedora-Everything-netinst-x86_64-38-20230216.n.0.iso has no icons in system menus or right click context menus. It may be fixed through enabling icons in the settings. I cannot test the Xfce Live ISO because trying to login bounces you back to the greeter. I am running xfce 4.18 on my F37 installation and everything is really smooth. My initial testing on F38 did not show this issue. I will see what's going on here. Thanks for filing the report. Much appreciated. this should have come from xfce4-settings but the values are correct there - <property name="MenuImages" type="bool" value="true"/> <property name="ButtonImages" type="bool" value="true"/> Weird The Live ISO Fedora-Xfce-Live-x86_64-38-20230219.n.0.iso nominated for testing has no icons in menus. I just tested the live CD and can see what you are referring to.
The xsettings.xml correctly sets the values necessary but weirdly enough it is not being used.
This is the entire file -
$ cat xfce-perchannel-xml/xsettings.xml
<?xml version="1.0" encoding="UTF-8"?>
<channel name="xsettings" version="1.0">
<property name="Net" type="empty">
<property name="ThemeName" type="empty"/>
</property>
<property name="Gtk" type="empty">
<property name="DecorationLayout" type="string" value="menu:minimize,maximize,close"/>
</property>
</channel>
Will you be able to file this issue upstream or should I?
If you are familiar with the where and how, it would be more efficient if you filed upstream. What is REALLY weird is that if you manually enable the settings in the GUI it starts working as expected, implying it's using a different settings file. (In reply to Ian Laurie from comment #6) > If you are familiar with the where and how, it would be more efficient if > you filed upstream. > No problem. I will file it. > What is REALLY weird is that if you manually enable the settings in the GUI > it starts working as expected, implying it's using a different settings file. YES! This is really strange. I spent quite a bit of time trying to find what data it's using with little success. I am not sure if this is session problem or settings ... @kevin Any ideas on solving this? The problem is the patch we have to set themes... Mar 02 01:18:19 localhost-live xfconfd[1596]: Error parsing xfconf config file "/etc/xdg/xfce4/xfconf/xfce-perchannel-xml/xsettings.xml": Invalid type for <property>: "Adwaita" We have: + <property name="ThemeName" type="Adwaita"/> + <property name="IconThemeName" type="Adwaita"/> but that should be: type="string" value="Adwaita" I think fixing that will fix it. You got it? Or would you like me to? (In reply to Kevin Fenzi from comment #11) > The problem is the patch we have to set themes... > > Mar 02 01:18:19 localhost-live xfconfd[1596]: Error parsing xfconf config > file "/etc/xdg/xfce4/xfconf/xfce-perchannel-xml/xsettings.xml": Invalid type > for <property>: "Adwaita" > > We have: > > + <property name="ThemeName" type="Adwaita"/> > + <property name="IconThemeName" type="Adwaita"/> > > but that should be: type="string" value="Adwaita" > > I think fixing that will fix it. > > You got it? Or would you like me to? I have stared at that patch for so long and never caught it! Thanks for looking at it. I will push this. Don't feel bad at all... It took me a good long while to get to the problem too. ;) FEDORA-2023-f07f5eede6 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f07f5eede6 As per comment on https://bodhi.fedoraproject.org/updates/FEDORA-2023-f07f5eede6 this bug seems fixed. A fresh VM install from the ISO shows the issue of missing icons, and updating with the bundle brings the icons back. This fix needs to make it through the freeze somehow. FEDORA-2023-f07f5eede6 has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f07f5eede6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. Proposed as a Freeze Exception for 38-beta by Fedora user nixuser using the blocker tracking app because: This bug had been fixed https://bodhi.fedoraproject.org/updates/FEDORA-2023-f07f5eede6 and not only brings icons back, but results in themes working also. Without this fix, Xfce is very ugly out of the box, and will give beta testers a very poor impression. +3 in https://pagure.io/fedora-qa/blocker-review/issue/1071 , marking accepted. FEDORA-2023-f07f5eede6 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |