Bug 2170716

Summary:	Custom partitioning confirmation dialog never appears after clicking Done
Product:	[Fedora] Fedora	Reporter:	Adam Williamson <awilliam>
Component:	mutter	Assignee:	GNOME SIG Unassigned <gnome-sig>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	39	CC:	anaconda-maint-list, fmuellner, gnome-sig, jadahl, mclasen, otaylor, philip.wyett, vponcova, vslavik, walters, w
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	openqa
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-02-14 21:24:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Adam Williamson 2023-02-17 03:07:58 UTC

Since Fedora-Rawhide-20230216.n.2 , with both regular custom and blivet custom partitioning, after completing the partition layout and clicking Done, the "SUMMARY OF CHANGES" confirmation dialog never appears. anaconda.log shows these as the last messages:

18:21:43,371 DBG ui.lib.storage: Validation has been completed: ValidationReport(error_messages=[], warning_messages=[])
18:21:43,601 DBG ui.lib.storage: Partitioning has been applied.

and then the installer is just stuck with the screen kinda dimmed but the confirm dialog not showing, like this: https://openqa.fedoraproject.org/tests/1761979#step/disk_custom_blivet_lvm_ext4/42

I assume this is caused by something in 38.22-1 or 38.23-1.

Comment 1 Adam Williamson 2023-02-17 04:21:54 UTC

alternatively, it could somehow be caused by mutter  or gnome-kiosk 44, I guess. That's in Rawhide but not Branched yet, and this bug is showing in Rawhide but not branched.

Comment 2 Vendula Poncova 2023-02-17 14:01:13 UTC

When I modify the glade file of the Summary dialog and add `<property name="decorated">False</property>` to `<object class="GtkDialog" id="summaryDialog">`, the dialog is displayed as it should be. This dialog is decorated to make it resizable (see https://github.com/rhinstaller/anaconda/commit/3762715233d15c03a434a2c53663f4c643afb879). Anyway, it looks like decorated Gtk dialogs are no longer shown for some reason. Since our fix would disable the resizability of the dialog, so I am reassigning this bug to Gtk.

Comment 3 Adam Williamson 2023-02-17 17:11:46 UTC

As mccatanzaro pointed out, gtk3 didn't change since Feb 8, so the thing that most likely changed to trigger this is mutter. Let's put it there for now.

Note, the new mutter adds a dep on gtk4. To avoid dep issues in the installer environment, we had to strip /usr/bin/* from gtk4 in the installer env cleanup. I'm running a scratch build of lorax with that removed (and libtiff left in - libtiff being stripped is the reason we had to remove gtk4's binaries...) to see if it changes this. I don't *think* it should, but it seemed worth testing.

Comment 4 Adam Williamson 2023-02-17 21:50:46 UTC

Oof, OK - an initial test suggests that leaving gtk4 /usr/bin/* and all of libtiff in the ISO *does* fix this bug. I'm gonna confirm that, but if so...I guess we have to eat the space usage :(

Comment 5 Adam Williamson 2023-02-17 22:28:02 UTC

https://github.com/weldr/lorax/pull/1312

Comment 6 Fedora Release Engineering 2023-08-16 08:06:56 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.

Comment 7 Fedora Admin user for bugzilla script actions 2024-02-14 12:20:10 UTC

This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 8 Adam Williamson 2024-02-14 21:24:45 UTC

we merged this ages ago.