Bug 217076

Summary: ChapMS2 is broken in pppd-2.4.4
Product: [Fedora] Fedora Reporter: gknispel
Component: pppAssignee: Martin Nagy <mnagy>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: hripps
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-03-12 09:31:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch which fix the bug none

Description gknispel 2006-11-23 19:48:15 UTC 
Description of problem:
from 2.4.3 to 2.4.4 "response" in ChapMS2() has been changed from a pointer to
structure to a pointer to unsigned char but a sizeof(*response) has not been
modified in a BZERO call, so pppd generate bad response packets when using this
protocol

Version-Release number of selected component (if applicable):
N/A

How reproducible:
Always

Steps to Reproduce:
1. Try to connect to a paranoid pptp server using MS-Chap-V2 and if it check for
empty fields where the RFC says fields must be empty it will fail...
2.
3.
  
Actual results:
You can't connect to some pptp servers

Expected results:
You should be able to connect to those pptp servers

Additional info:
A patch is attached
I'll send it upstream too...
Comment 1 gknispel 2006-11-23 19:48:16 UTC 
Created attachment 142009 [details]
Patch which fix the bug
Comment 2 Martin Nagy 2008-03-12 09:31:14 UTC 
Fixed in ppp-2.4.4-6.fc9
Comment 3 Martin Nagy 2008-03-12 09:46:43 UTC 
Changing component back to ppp, I have no idea how the heck did it change to
"4suite"