Bug 217195

Summary:	XMMS segfaults when selecting directory with .rar file and no unrar installed
Product:	[Fedora] Fedora	Reporter:	Bas Mevissen <abuse>
Component:	xmms-modplug	Assignee:	Ville Skyttä <ville.skytta>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6	CC:	extras-qa
Target Milestone:	---
Target Release:	---
Hardware:	i386
OS:	Linux
Whiteboard:
Fixed In Version:	2.05-8	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-12-12 16:47:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Bas Mevissen 2006-11-25 00:21:18 UTC

Description of problem:
XMMS segfaults when loading a directory of music containing a .rar file and
unrar is not installed. Note that this is the only use case I checked, it might
be a larger problem.

Version-Release number of selected component (if applicable):
xmms-1.2.10-29.fc6

How reproducible:
Every time.

Steps to Reproduce:
1. Start XMMS from the command line and press the ">" play button
2. Select a directory of music files containing a .rar file
3. Press "Add all files in a directory"
4. Press "Play"
Note that the directory I pointed to was also the directory I started XMMS in
and the directory contains subdirectories with also .mp3 files.
  
Actual results:
xmms 
XS[src/xmms-sid.c:xs_init:216]: xs_init()
XS[src/xs_config.c:xs_init_configuration:164]: initializing configuration ...
XS[src/xs_config.c:xs_read_configuration:265]: loading from config-file ...
XS[src/xs_config.c:xs_read_configuration:320]: OK
XS[src/xmms-sid.c:xs_reinit:163]: initializing emulator engine #1...
XS[src/xmms-sid.c:xs_reinit:177]: init#1: OK, 1
XS[src/xmms-sid.c:xs_reinit:189]: init#2: OK, 0
XS[src/xmms-sid.c:xs_init:226]: OK
sh: unrar: command not found

Segmentation fault

You've probably found a bug in XMMS, please visit
http://bugs.xmms.org and fill out a bug report.

Expected results:
Complaining that unrar was not found, but continuing action.
With unrar installed, application does not segfault (but other problem found:
xmms hangs, this will be a separate bug report).

Additional info:
Clean FC6 install on a big Intel Core Duo 2 system.

Comment 1 Bas Mevissen 2006-11-25 00:26:48 UTC

Filed upstream as http://bugs.xmms.org/show_bug.cgi?id=2450

Comment 2 Ville Skyttä 2006-11-26 17:07:11 UTC

I don't see any code in xmms that would handle rar archives any way or call
unrar.  What plugins do you have installed (rpm -qa "xmms*")?  At least
xmms-modplug appears to have some unrar stuff in it.

Comment 3 Bas Mevissen 2006-12-11 17:41:03 UTC

I thought I already submitted this, but somehow it disappeared:

$ rpm -qa "xmms*"
xmms-xosd-2.2.14-8.fc6
xmms-skins-1.2.10-15
xmms-sid-0.8.0-0.3.beta15.fc6
xmms-speex-0.9.1-8.fc6
xmms-lirc-1.4-9.fc6
xmms-faad2-2.0-19.20050131.lvn6
xmms-1.2.10-29.fc6
xmms-adplug-1.2-3.fc6
xmms-arts-0.7.1-4.fc6
xmms-devel-1.2.10-29.fc6
xmms-crossfade-0.3.11-1.fc6
xmms-alarm-0.3.7-5.fc6
xmms-libs-1.2.10-29.fc6
xmms-modplug-2.05-7.fc6
xmms-cdread-0.14-12.fc6
xmms-musepack-1.2-3.fc6
xmms-mp3-1.2.10-5.lvn6
xmms-normalize-0.7.7-2.lvn6
xmms-acme-0.4.3-6.fc6
xmms-esd-1.2.10-29.fc6
xmms-scrobbler-0.3.8.1-2.fc6
xmms-flac-1.1.2-27.fc6

Comment 4 Ville Skyttä 2006-12-11 19:02:57 UTC

Does the crash occur if xmms-modplug is not installed?

Comment 5 Bas Mevissen 2006-12-11 22:11:22 UTC

No, after removing xmms-modplug, no crash appears.

Note that just the existence of a file foo.rar without any contents does crash
xmms if xmms-modplug is installed and unrar isn't.

Comment 6 Ville Skyttä 2006-12-11 22:37:58 UTC

Should be fixed in upcoming xmms-modplug 2.05-8.fc*

Comment 7 Bas Mevissen 2006-12-11 22:48:05 UTC

Nice. Please tell me when available somewhere so I can test and confirm fix.

Comment 8 Ville Skyttä 2006-12-11 22:55:17 UTC

Just completed (unsigned) builds from the build system:
http://buildsys.fedoraproject.org/plague-results/fedora-6-extras/xmms-modplug/2.05-8.fc6/

Comment 9 Bas Mevissen 2006-12-11 23:07:28 UTC

Confirmed: problem is solved with these new packages. Works fine with or without
unrar installed etc.

Thanks for the good work!