Bug 2172112
| Summary: | Review Request: workflow - C++ Parallel Computing and Asynchronous Networking Engine | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Felix Wang <topazus> | ||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | admiller, benson_muite, leamas.alec, michel, ngompa13, package-review, pingou | ||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review?
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://github.com/sogou/workflow | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-02-22 04:22:38 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Felix Wang
2023-02-21 14:25:41 UTC
Taking this review. Initial spec review:
> %exclude %{_docdir}/workflow-0.10.5/README.md
Don't use "%exclude" this way.
Instead, "rm -rf %{buildroot}%{_docdir}/%{name}-%{version}" in the install section after "%cmake_install".
Thanks for your pointing out my mistake. update: Spec URL: https://download.copr.fedorainfracloud.org/results/topazus/test/fedora-rawhide-x86_64/05555388-workflow/workflow.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/topazus/test/fedora-rawhide-x86_64/05555388-workflow/workflow-0.10.5-1.fc39.src.rpm koji build of rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=97834699 > Source: https://github.com/sogou/workflow/archive/v%{version}/%{name}-%{version}.tar.gz You can simplify the Source: value to "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz" > %global _description %{expand: > As Sogou`s C++ server engine, Sogou C++ Workflow supports almost all back-end > C++ online services of Sogou, including all search services, cloud input > method, online advertisements, etc., handling more than 10 billion requests > every day. This is an enterprise-level programming engine in light and elegant > design which can satisfy most C++ back-end development requirements.} > > %description %{_description} This is unnecessary abstraction. The description is used in only one place, so you can eliminate the variable. Copr build: https://copr.fedorainfracloud.org/coprs/build/5555675 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2172112-workflow/fedora-rawhide-x86_64/05555675-workflow/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I modified as you advised. Thanks. Spec URL: https://download.copr.fedorainfracloud.org/results/topazus/test/fedora-rawhide-x86_64/05555726-workflow/workflow.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/topazus/test/fedora-rawhide-x86_64/05555726-workflow/workflow-0.10.5-1.fc39.src.rpm Created attachment 1945656 [details]
The .spec file difference from Copr build 5555675 to 5555733
Copr build: https://copr.fedorainfracloud.org/coprs/build/5555733 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2172112-workflow/fedora-rawhide-x86_64/05555733-workflow/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This is a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=2157252 *** This bug has been marked as a duplicate of bug 2157252 *** (In reply to Benson Muite from comment #9) > This is a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=2157252 apologized for the inconvenience I brought the duplicate review request for you. Would welcome co-maintainer if approved. |