Bug 2172392
| Summary: | %gopkgfiles packages dir owned by all other go packages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andreas Schneider <asn> |
| Component: | golang | Assignee: | Alejandro Sáez Morollón <asm> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 37 | CC: | amurdaca, asm, asn, deparker, dwd, eduardo.ramalho, go-sig, jcajka, lemenkov, mattioli.fernando, maxwell, quantum.analyst, tommi.t.rantala, zebob.m |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | golang-1.21~rc3-1.fc39 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-07-18 16:09:59 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
rpm -qf /usr/share/gocode/src/ go-filesystem-3.2.0-1.fc37.x86_64 golang-1.19.6-1.fc37.x86_64 Shouldn't golang require go-filesystem? We shouldn't own anything under /usr/share/gocode/src in go-filesystem. While github.com is popular git forge, it's not inherent to golang. As for /usr/share/gocode/src itself, I'll look into that. I don't think It should be owned by both golang and go-filesystem. (In reply to Andreas Schneider from comment #1) > rpm -qf /usr/share/gocode/src/ > go-filesystem-3.2.0-1.fc37.x86_64 > golang-1.19.6-1.fc37.x86_64 > > Shouldn't golang require go-filesystem? Yes, I think so, or at least that is what I understood from this section of the documentation[0]. I ran a COPR build with the Requires of go-filesystem and fedora-review doesn't complain anymore: [x]: Package does not own files or directories owned by other packages. If nobody has something against the idea, I can add it. [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function FEDORA-2023-1841adf030 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1841adf030 FEDORA-2023-1841adf030 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |
Description of problem: The fedora-review tool reports: [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com(golang-github-bradfitz-gomemcache- devel, golang-github-marcinbor85-gohex-devel, golang-github-gorilla- mux-devel, golang-github-glog-devel, golang-github-kr-binarydist- devel, golang-github-xeipuuv-gojsonschema-devel, golang-github-tj- spin-devel, golang-github-cheekybits-is-devel, golang-github- projectdiscovery-goconfig-devel, golang-github-vividcortex-ewma-devel, golang-github-yory8-clipman-devel, golang-github-shurcool- githubv4-devel, golang-github-xanzy-ssh-agent-devel, golang-github- ssdb-gossdb-devel, golang-github-mwitkow-conntrack-devel, golang- github-jellevandenhooff-dkim-devel, golang-github-eknkc-amber-devel, golang-github-projectdiscovery-iputil-devel, golang-github-marstr- collection-devel, golang-github-docker-slim-uilive-devel, golang- github-googlecloudplatform-cloudsql-proxy-devel, golang-github- wellington-libsass-devel, golang-github-miekg-mmark-devel, golang- github-simonpasquier-klog-gokit-devel, golang-github-bep-goat-devel, golang-github-teris-io-shortid-devel, golang-github-yudai-golcs-devel, golang-github-apparentlymart-dump-devel, golang-github-containerd-nri- devel, golang-github-moby-locker-devel, golang-github-xi2-xz-devel, golang-github-trafficstars-metrics-devel, golang-github-zyedidia-pty- devel, golang-github-monochromegane-gitignore-devel, golang-github- influxdb-gomdb-devel, golang-github-minio-6-devel, golang-github- valyala-fasthttp-devel, golang-github-gin-gonic-devel, golang-github- vmware-govcloudair-devel, golang-github-jackc-pgio-devel, golang- github-vishvananda-netlink-devel, golang-github-containerd-ttrpc- devel, golang-github-masterminds-vcs-devel, golang-github-schollz- logger-devel, golang-github-tklauser-numcpus-devel, golang-github- inconshreveable-mousetrap-devel, golang-github- muhammadmuzzammil1998-jsonc-devel, golang-github-dgnorton-goback- devel, golang-github-marekm4-color-extractor-devel, golang-github- bfirsh-funker-devel, golang-github-inhies-bytesize-devel, golang- github-gosuri-uilive-devel, golang-github-piprate-json-gold-devel, golang-github-containerd-imgcrypt-devel, golang-github-buengese-sgzip- devel, golang-github-smartystreets-gunit-devel, golang-github-ugorji- devel, golang-github-spf13-pflag-devel, golang-github-sylabs-json- resp-devel, golang-github-cncf-xds-devel, compat-golang-github-xorm- core-devel, golang-github-gokyle-twofactor-devel, golang-github- iguanesolutions-systemd-5-devel, golang-github-m4ll0k-aron-devel, golang-github-paulrosania-charset-devel, golang-github-urfave-cli- devel, golang-github-antchfx-xmlquery-devel, golang-github-xaionaro- unsafetools-devel, golang-github-tomnomnom-httprobe-devel, golang- github-msteinert-pam-devel, golang-github-redcode-labs-snowcrash- devel, golang-github-netflix-expect-devel, ... I guess /usr/share/gocode/src/github.com should be owned by go-filesystem and added as a BuildRequires and Requires.