Bug 2172445

We can disable USD support until bug 2172762 is worked out, but it still doesn’t seem like Blender is successfully patched for embree 4.x.

$ fedpkg prep
$ grep -FrnI embree3 blender-3.4.1
blender-3.4.1/build_files/build_environment/cmake/embree.cmake:55:      COMMAND ${CMAKE_COMMAND} -E copy ${LIBDIR}/embree/lib/embree3.lib ${HARVEST_TARGET}/embree/lib/embree3_d.lib
blender-3.4.1/build_files/cmake/Modules/FindEmbree.cmake:26:    embree3/rtcore.h
blender-3.4.1/build_files/cmake/Modules/FindEmbree.cmake:42:  embree3
blender-3.4.1/build_files/cmake/platform/platform_win32.cmake:795:      optimized ${LIBDIR}/embree/lib/embree3.lib
blender-3.4.1/build_files/cmake/platform/platform_win32.cmake:805:      debug ${LIBDIR}/embree/lib/embree3_d.lib
blender-3.4.1/intern/cycles/bvh/embree.cpp:20:#  include <embree3/rtcore_geometry.h>
blender-3.4.1/intern/cycles/bvh/embree.h:9:#  include <embree3/rtcore.h>
blender-3.4.1/intern/cycles/bvh/embree.h:10:#  include <embree3/rtcore_scene.h>
blender-3.4.1/intern/cycles/device/cpu/device_impl.cpp:17:#  include <embree3/rtcore.h>
blender-3.4.1/intern/cycles/device/cpu/device_impl.h:14:#  include <embree3/rtcore.h>
blender-3.4.1/intern/cycles/kernel/device/cpu/bvh.h:8:#include <embree3/rtcore_ray.h>
blender-3.4.1/intern/cycles/kernel/device/cpu/bvh.h:9:#include <embree3/rtcore_scene.h>
blender-3.4.1/intern/cycles/kernel/types.h:7:#  include <embree3/rtcore.h>
blender-3.4.1/intern/cycles/kernel/types.h:8:#  include <embree3/rtcore_scene.h>

Do you have a plan? Do you need help?

Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on devel.org if you are unsure how to fix this bug.

(In reply to Ben Beasley from comment #1)
> We can disable USD support until bug 2172762 is worked out, but it still
> doesn’t seem like Blender is successfully patched for embree 4.x.
>

Sorry for delay. I packed embree3 to keep compatibility for both blender and luxcorerender. It seems USD still caused failure and needs rebuild. See https://koschei.fedoraproject.org/package/blender

Now that USD is patched and rebuilt, the problem is a missing #include:

/builddir/build/BUILD/blender-3.4.1/intern/locale/boost_locale_wrapper.cpp:112:1
0: error: 'cout' is not a member of 'std'
  112 |     std::cout << "bl_locale_set(" << locale << "): " << e.what() << " \n
"; 
      |          ^~~~
/builddir/build/BUILD/blender-3.4.1/intern/locale/boost_locale_wrapper.cpp:12:1:
 note: 'std::cout' is defined in header '<iostream>'; did you forget to '#includ
e <iostream>'?
   11 | #include "boost_locale_wrapper.h"
  +++ |+#include <iostream>
   12 |
/builddir/build/BUILD/blender-3.4.1/intern/locale/boost_locale_wrapper.cpp:115:1
0: error: 'cout' is not a member of 'std'
  115 |     std::cout << "bl_locale_set(" << locale << "): " << e.what() << " \n";
      |          ^~~~
/builddir/build/BUILD/blender-3.4.1/intern/locale/boost_locale_wrapper.cpp:115:10: note: 'std::cout' is defined in header '<iostream>'; did you forget to '#include <iostream>'?

Will you take care on addressing the issue? I currently lack the time fix it this week. Thanks.

I’ve backported https://projects.blender.org/blender/blender/commit/79837c5ed4b57925bf6c6bb9e7c2248f6f52bbb0. If test-builds (mock then scratch) succeed, a real build should close this bug sometime today.

I’m happy to see that Blender has very recently switched from Phabricator to a customized GitHub system. That will make it a lot less frustrating to send small fixes upstream.

(In reply to Ben Beasley from comment #6)
> I’ve backported
> https://projects.blender.org/blender/blender/commit/
> 79837c5ed4b57925bf6c6bb9e7c2248f6f52bbb0. If test-builds (mock then scratch)
> succeed, a real build should close this bug sometime today.

The mock build succeeded without further changes. The scratch build is starting. Barring any real surprises, we can expect the real build to complete a couple of hours from now.

FEDORA-2023-8742ca346d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8742ca346d

FEDORA-2023-8742ca346d has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.