Bug 2172617

Summary:	libfplll: data missing from header files
Product:	[Fedora] Fedora	Reporter:	Jerry James <loganjerry>
Component:	libfplll	Assignee:	Ben Beasley <code>
Status:	ASSIGNED ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	39	CC:	code, loganjerry, paulo.cesar.pereira.de.andrade
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jerry James 2023-02-22 18:02:34 UTC

Description of problem:
I was just looking at a python-fpylll issue (https://github.com/fplll/fpylll/issues/221).  There is a proposed fix for the issue, but it requires libfplll to have good values for FPLLL_DEFAULT_STRATEGY_PATH and FPLLL_DEFAULT_STRATEGY in /usr/include/fplll/defs.h.  In Rawhide, at least, both of those are empty strings.  They should be:

#ifndef FPLLL_DEFAULT_STRATEGY_PATH
#define FPLLL_DEFAULT_STRATEGY_PATH "/usr/share/fplll/strategies"
#endif

#ifndef FPLLL_DEFAULT_STRATEGY
#define FPLLL_DEFAULT_STRATEGY "default.json"
#endif

While poking around, I also noticed that fplll_config.h has this:

#define FPLLL_SONUM @FPLLL_SONUM@

which probably doesn't do anybody any good.  I don't know that anything consumes FPLLL_SONUM, but we should probably see why substitution failed there.

None of this is urgent.  I'm just filing a bug so it doesn't get forgotten.  We should fix it sometime.

Version-Release number of selected component (if applicable):
libfplll-5.4.4-2.fc38

How reproducible:
N/A

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Ben Beasley 2023-02-22 18:45:03 UTC

Thanks for reporting these. I’ve asked upstream what they want to do about the FPLLL_SONUM macro[1], which I suspect has never had a usable value.

I agree about the correct values of the strategy path macros. I will look into whether this is an upstream bug or an issue with the way we are building the package.

[1] https://github.com/fplll/fplll/issues/509

Comment 2 Ben Beasley 2023-02-22 19:18:25 UTC

I have commented on the fpylll upstream issue[1] and opened an issue with fplll upstream[2] to talk about it. I’ll wait a little while for discussion and then patch this downstreame-only if I have to.

[1] https://github.com/fplll/fpylll/issues/221#issuecomment-1440653252
[2] https://github.com/fplll/fplll/issues/510

Comment 3 Jerry James 2023-02-22 21:27:52 UTC

Thanks for the quick action, Ben.  I'll keep an eye on those upstream issues.

Comment 4 Ben Beasley 2023-03-04 14:03:17 UTC

I suggested a patch upstream[1]. I am waiting for maintainer and community review before doing anything to the Fedora package.

[1] https://github.com/fplll/fplll/pull/512

Comment 5 Fedora Release Engineering 2023-08-16 08:14:49 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.