Bug 217281

Summary: The init script gets 'condrestart' argument wrong
Product: Red Hat Enterprise Linux 5 Reporter: Radek Bíba <rbiba>
Component: wpa_supplicantAssignee: Dan Williams <dcbw>
Status: CLOSED ERRATA QA Contact:
Severity: low Docs Contact:
Priority: medium    
Version: 5.0CC: shillman
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: RHBA-2008-0473 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-05-21 17:33:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Radek Bíba 2006-11-26 13:24:04 UTC
Description of problem:
/etc/rc.d/init.d/wpa_supplicant reads:

case "$1" in
...
        condrestart|try-restart)
                [ -f $lockfile ] || restart
                ;;
...

This is wrong. condrestart (or try-restart) is supposed to restart a service
as long as it's running. So, it should read either:
[ -f $lockfile ] && restart
or:
[ ! -f $lockfile ] || restart

See the other /etc/rc.d/init.d/* scripts.

Comment 1 Dan Williams 2007-11-05 15:49:59 UTC
trivial fix, could do for 5.2

Comment 2 RHEL Program Management 2007-11-27 21:54:40 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 4 Dan Williams 2008-01-16 22:22:07 UTC
Fix committed to RHEL5 branch

Comment 12 errata-xmlrpc 2008-05-21 17:33:36 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2008-0473.html