Bug 2172854

Summary: Install to Hard Drive Desktop Icon is not marked as executable
Product: [Fedora] Fedora Reporter: seanmottles
Component: livesys-scriptsAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 38CC: awilliam, dan, foss.sr0n6, geraldo.simiao.kutz, kparal, ngompa13, nonamedotc
Target Milestone: ---Keywords: CommonBugs
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AcceptedFreezeException https://discussion.fedoraproject.org/t/80851
Fixed In Version: livesys-scripts-0.4.3-1.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-04-15 02:08:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2083913    
Attachments:
Description Flags
Screenshot of XFCE intsaller desktop and prompt
none
Screenshot of Xfce F38 Beta 1.2 desktop and prompt none

Description seanmottles 2023-02-23 10:14:02 UTC
Created attachment 1945895 [details]
Screenshot of XFCE intsaller desktop and prompt

Description of problem:

The "Install to Hard Drive" desktop icon on the XFCE Live CD is not marked as an executable and upon double clicking brings up an "Untrusted application launcher" prompt.


Version-Release number of selected component (if applicable):

Fedora-Xfce-Live-x86_64-38-20230222.n.0.iso

How reproducible:

Every time.

Steps to Reproduce:
1. Download latest F38 XFCE installer ISO and run it
2. Double click "Install to Hard Drive" desktop icon

Actual results:

Untrusted application launcher prompt is shown.

Expected results:

Anaconda starts without warnings.

Additional info:

Comment 1 Dan Horák 2023-02-23 10:52:11 UTC
I think the issue is with the livesys-scripts package, as its scripts install the launcher, moving accordingly ...

Comment 2 Neal Gompa 2023-03-05 13:43:19 UTC
We definitely mark it as executable though: https://pagure.io/livesys-scripts/blob/main/f/libexec/livesys/sessions.d/livesys-xfce#_46-47

Comment 3 seanmottles 2023-03-07 12:07:53 UTC
Still present in Fedora-Xfce-Live-x86_64-38_Beta-1.2.iso

Comment 4 seanmottles 2023-03-07 12:08:39 UTC
Created attachment 1948663 [details]
Screenshot of Xfce F38 Beta 1.2 desktop and prompt

Comment 5 seanmottles 2023-03-17 11:29:05 UTC
Still present in F38 Beta 1.3 and Fedora-Xfce-Live-x86_64-38-20230315.n.0.iso

Comment 6 seanmottles 2023-04-04 09:54:16 UTC
Looks like while the icon _is_ marked as executable, the liveuser's Desktop is not trusted. The change to /etc/environment in the following PR works for me:

https://pagure.io/livesys-scripts/pull-request/13

Comment 7 seanmottles 2023-04-05 15:49:10 UTC
merged proper method of addressing this: https://pagure.io/livesys-scripts/pull-request/14

just needs a new package built and this should be fixed! Thanks Neal and Mukundan for your help! :)

Comment 8 Fedora Blocker Bugs Application 2023-04-11 12:16:04 UTC
Proposed as a Freeze Exception for 38-final by Fedora user seaninspace using the blocker tracking app because:

 Updates the Xfce Spin's Install to Hard Drive desktop icon so that an "Untrusted Application Launcher" warning no longer prompts the user and Anaconda starts normally.

Comment 9 Kevin Fenzi 2023-04-11 18:00:19 UTC
*** Bug 2185236 has been marked as a duplicate of this bug. ***

Comment 10 Adam Williamson 2023-04-11 18:41:20 UTC
+4 FE in https://pagure.io/fedora-qa/blocker-review/issue/1149 , marking accepted.

Comment 11 Adam Williamson 2023-04-11 18:42:47 UTC
Neal, can you please do an update for this so we can put it in RC-1.2? Thanks.

Comment 12 Fedora Update System 2023-04-11 19:09:52 UTC
FEDORA-EPEL-2023-23069324a3 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-23069324a3

Comment 13 Fedora Update System 2023-04-11 19:09:54 UTC
FEDORA-EPEL-2023-3e895607b0 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-3e895607b0

Comment 14 Fedora Update System 2023-04-11 19:09:55 UTC
FEDORA-2023-4193851905 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4193851905

Comment 15 Fedora Update System 2023-04-11 19:09:56 UTC
FEDORA-2023-1ef83c76e4 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1ef83c76e4

Comment 16 Fedora Update System 2023-04-11 22:15:09 UTC
FEDORA-2023-1ef83c76e4 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-1ef83c76e4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Kamil Páral 2023-04-12 07:38:57 UTC
The problem is still the same in Fedora-Xfce-Live-x86_64-38-1.4.iso.

Comment 18 seanmottles 2023-04-12 09:29:47 UTC
Looks like the gio command needs to be ran as the liveuser in order for that to work, running as root returns:

gio: Setting attribute metadata xfce-exe-checksum not supported

I'll submit a fix.

Comment 19 seanmottles 2023-04-12 09:47:21 UTC
https://pagure.io/livesys-scripts/pull-request/15 hopefully the last one :)

Comment 20 Geraldo Simião 2023-04-12 14:41:47 UTC
This here is working fine, thanks Sean for the input on how to test it: https://bodhi.fedoraproject.org/updates/FEDORA-2023-76b7e94b44

Comment 21 Adam Williamson 2023-04-12 15:42:08 UTC
Thanks. Neal, please **DO NOT** edit the in-flight livesys-scripts update, if we ship the current RC we will have to push that livesys-scripts stable even though it didn't actually fix the bug.

Comment 22 Fedora Update System 2023-04-13 02:53:41 UTC
FEDORA-2023-76b7e94b44 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-76b7e94b44

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 23 Neal Gompa 2023-04-13 20:24:49 UTC
(In reply to Adam Williamson from comment #21)
> Thanks. Neal, please **DO NOT** edit the in-flight livesys-scripts update,
> if we ship the current RC we will have to push that livesys-scripts stable
> even though it didn't actually fix the bug.

I tried not to. Bodhi did it automatically.

Comment 24 Adam Williamson 2023-04-13 22:41:07 UTC
It didn't really edit it, but creating a new one automatically obsoletes the old one. Oh well, we dealt with it.

Comment 25 Fedora Update System 2023-04-15 02:08:02 UTC
FEDORA-2023-76b7e94b44 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.