Bug 2172910

Summary:	Tests for pino testsuite failing when used with Node.js 16
Product:	Red Hat Enterprise Linux 9	Reporter:	Petr Kubat <pkubat>
Component:	nodejs	Assignee:	Lucas Holmquist <lholmqui>
Status:	CLOSED MIGRATED	QA Contact:	RHEL CS Apps Subsystem QE <rhel-cs-apps-subsystem-qe>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	9.1	CC:	hhorak, jstanek, pkubat
Target Milestone:	rc	Keywords:	MigratedToJIRA
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-09-20 15:10:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Kubat 2023-02-23 13:45:54 UTC

Description of problem:
Pino testsuite fails when used with Node.js 16 on RHEL9. Seems to work fine in RHEL8 and with upstream version (according to Michael Dawson).

Version-Release number of selected component (if applicable):
$ node --version
v16.18.1

How reproducible: always


Steps to Reproduce:
1. podman run --rm -ti ubi9/nodejs-16 bash -c "git clone --branch v8.11.0 --depth 1 https://github.com/pinojs/pino.git && cd pino && npm install && npm test"

Actual results:
FAIL  test/syncfalse.test.js
 ✖ should be equal

  test/syncfalse.test.js                   
  50 |   await once(child, 'close')        
  51 |   equal(actual, expected)           
> 52 |   equal(actual2.trim(), expected2)  
     | --^                                 
  53 |                                     
  54 |   teardown(() => {                  
  55 |     os.hostname = hostname          

  test: test/syncfalse.test.js asynchronous logging
  found: ""
  wanted: '{"level":30,"time":1459875739796,"pid":123456,"hostname":"abcdefghijklmnopqr","msg":"h"}'
  compare: ===
  stack: |
    Test.<anonymous> (test/syncfalse.test.js:52:3)

+ hangs here forever.

Expected results:
Pass

Additional info:

Comment 1 Petr Kubat 2023-02-23 13:51:42 UTC

Some discussion in: https://github.com/sclorg/s2i-nodejs-container/pull/378

Comment 2 Honza Horak 2023-04-18 15:03:40 UTC

It fails differently now, with the same reproducer:

> pino.0 transpile
> node ./test/fixtures/ts/transpile.cjs

 FAIL  test/browser.test.js
 ✖ pino.stdSerializers.errWithCause

  test: test/browser.test.js
  operator: ok
  expected: true
  actual: undefined
  at: Test.<anonymous> (/opt/app-root/src/pino/test/browser.test.js:101:5)
  stack: >-
    Error: pino.stdSerializers.errWithCause
        at Test.assert [as _assert] (/opt/app-root/src/pino/node_modules/tape/lib/test.js:312:48)
        at Test.bound [as _assert] (/opt/app-root/src/pino/node_modules/tape/lib/test.js:95:17)
        at Test.assert (/opt/app-root/src/pino/node_modules/tape/lib/test.js:431:7)
        at bound (/opt/app-root/src/pino/node_modules/tape/lib/test.js:95:17)
        at Test.<anonymous> (/opt/app-root/src/pino/test/browser.test.js:101:5)
        at Test.bound [as _cb] (/opt/app-root/src/pino/node_modules/tape/lib/test.js:95:17)
        at Test.run (/opt/app-root/src/pino/node_modules/tape/lib/test.js:115:28)
        at Test.bound [as run] (/opt/app-root/src/pino/node_modules/tape/lib/test.js:95:17)
        at Immediate.next [as _onImmediate] (/opt/app-root/src/pino/node_modules/tape/lib/results.js:157:7)
        at process.processImmediate (node:internal/timers:471:21)

 SKIP  test/http.test.js
 ~ http request support via serializer without request connection

Comment 3 Honza Horak 2023-04-18 15:05:52 UTC

This seems to be a confirmed issue upstream: https://github.com/pinojs/pino/issues/1690

Comment 5 Honza Horak 2023-04-19 08:40:53 UTC

(In reply to Honza Horak from comment #3)
> This seems to be a confirmed issue upstream:
> https://github.com/pinojs/pino/issues/1690

Btw. this recent error in the test browser.test.js seems to be happening no matter what RHEL version or nodejs version we have in the container. And also outside container.

Comment 6 RHEL Program Management 2023-09-20 15:05:51 UTC

Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 7 RHEL Program Management 2023-09-20 15:10:55 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.