Bug 2173051

Summary:	dnf5 gets confused by path dependency in secondary
Product:	[Fedora] Fedora	Reporter:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Component:	dnf5	Assignee:	rpm-software-management
Status:	NEW ---	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	39	CC:	amatej, jkolarik, j, nsella, pkratoch, ppisar, rpm-software-management
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zbigniew Jędrzejewski-Szmek 2023-02-23 19:56:07 UTC

Description of problem:
I'm not sure exactly what is going on here, but 
sudo dnf5 upgrade --releasever=38 --enablerepo=updates-testing --setopt=install_weak_deps=0
fails to update a package:

Updating and loading repositories:
Repositories loaded.
Problem 1: package gnome-keyring-42.1-3.fc38.x86_64 requires /usr/libexec/gcr-ssh-askpass, but none of the providers can be installed
  - cannot install both gcr3-3.41.1-3.fc37.x86_64 and gcr3-3.41.1-5.fc38.x86_64
  - cannot install the best update candidate for package gnome-keyring-42.1-2.fc37.x86_64
  - cannot install the best update candidate for package gcr3-3.41.1-3.fc37.x86_64
 Problem 2: package gnome-keyring-42.1-3.fc38.x86_64 requires /usr/libexec/gcr-ssh-askpass, but none of the providers can be installed
  - package gcr3-3.41.1-3.fc37.x86_64 requires gcr3-base(x86-64) = 3.41.1-3.fc37, but none of the providers can be installed
  - package gnome-keyring-pam-42.1-3.fc38.x86_64 requires gnome-keyring(x86-64) = 42.1-3.fc38, but none of the providers can be installed
  - cannot install both gcr3-base-3.41.1-3.fc37.x86_64 and gcr3-base-3.41.1-5.fc38.x86_64
  - cannot install the best update candidate for package gnome-keyring-pam-42.1-2.fc37.x86_64
  - cannot install the best update candidate for package gcr3-base-3.41.1-3.fc37.x86_64

dnf4 has no problem with this and updates to gcr3-3.41.1-5.fc38.x86_64.

I assume that this is somehow related to the path dependency on /usr/libexec/gcr-ssh-askpass.

Version-Release number of selected component (if applicable):
dnf5-5.0.4-0.20230122005959.5.0.3+32.g9d0ed3d4.fc37.x86_64

How reproducible:
determnistic

Comment 1 Zbigniew Jędrzejewski-Szmek 2023-02-27 09:01:30 UTC

Oh, repoquery shows similar behaviour:

$ dnf5 repoquery --whatprovides /usr/libexec/gcr-ssh-askpass
Updating and loading repositories:
Repositories loaded.

$ dnf repoquery --whatprovides /usr/libexec/gcr-ssh-askpass
Last metadata expiration check: 0:01:18 ago on Mon 27 Feb 2023 09:59:01 AM CET.
gcr3-0:3.41.1-5.fc38.i686
gcr3-0:3.41.1-5.fc38.x86_64

But for paths under /usr/bin, both work. So maybe this is related to the
primary / filelists split somehow?

Comment 2 amatej 2023-02-27 14:59:50 UTC

Yes this is caused by the missing filelists metadata.

dnf5 doesn't download them by default.

They can be added via a new config option: optional_metadata_types either in the config:
optional_metadata_types=filelists
or on command line:
dnf5 repoquery --whatprovides /usr/libexec/gcr-ssh-askpass --setopt=optional_metadata_types=filelists

For repoquery this is most likely a bug, the path argument should trigger automatic filelists download. We do this for the pkg_spec argument to repoquery meaning this works and downloads the filelists automatically:
dnf5 repoquery /usr/libexec/gcr-ssh-askpass
I think we should also check if the arguments to --what* are paths.

But for the upgrade it would be more complicated. I think the best approach would be to change the dependency on /usr/libexec/gcr-ssh-askpass.

Comment 3 Petr Pisar 2023-02-27 16:31:55 UTC

There are opinions on how DNF5 should handle file dependencies (bug #1731700, comment #10).

Comment 4 Jason Tibbitts 2023-02-27 17:54:44 UTC

I think not breaking existing functionality qualifies as more than just "opinions".  I know there is a DNF5-related change that went through FESCo, but I don't think that it included any indication that packaging guidelines would need to change or that existing packages would become uninstallable in the default configuration.  I don't think there's a huge issue in getting the packages fixed and the guidelines changed, but there is a procedure for pushing breaking changes through the distribution that needs to be followed.  In the absence of that, I think allowing but discouraging arbitrary file dependencies is the proper choice, and that's what we do now. The fact that there is any discouragement at all only comes from old yum behavior, where it would download the larger file lists only when needed.

Comment 5 Jaroslav Mracek 2023-03-06 10:24:03 UTC

To download filelists, you can use `--setopt=optional_metadata_types=filelists`.

There are more packages in fedora distribution that does not follow packaging guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies).

We have two options
1. fight with package maintainers to follow packaging guidelines
   - replace a require according to guidelines
   - provide explicitly the require
2. Change default in DNF5 and load again filelists - no change to do any improvements


Here is a list of nonstandard file requires in Fedora 38 that are not explicitly provided by any package:

/sbin/ldconfig
/sbin/mount.nfs
/sbin/mount.nfs4
/sbin/rpc.statd
/usr/lib/cmake
/usr/lib/kbd
/usr/lib/ocf/resource.d
/usr/lib64/cmake
/usr/lib64/libnssckbi.so
/usr/lib64/mpich/bin/mpibash_mpich
/usr/lib64/mpich/bin/scorep-config
/usr/lib64/openmpi/bin/mpibash_openmpi
/usr/lib64/openmpi/bin/scorep-config
/usr/libexec/gcr-ssh-askpass
/usr/libexec/virtiofsd
/usr/share/X11/rgb.txt
/usr/share/dict/words
/usr/share/fonts/google-droid-sans-fonts/DroidSans.ttf
/usr/share/fonts/google-droid-sans-fonts/DroidSansFallbackFull.ttf
/usr/share/lightsquid/common.pl
/usr/share/sqlninja/backscan.pl
/usr/share/sqlninja/bruteforce.pl
/usr/share/sqlninja/dirshell.pl
/usr/share/sqlninja/dns.pl
/usr/share/sqlninja/escalation.pl
/usr/share/sqlninja/fingerprint.pl
/usr/share/sqlninja/getdata.pl
/usr/share/sqlninja/icmp.pl
/usr/share/sqlninja/metasploit.pl
/usr/share/sqlninja/resurrectxp.pl
/usr/share/sqlninja/revshell.pl
/usr/share/sqlninja/session.pl
/usr/share/sqlninja/sqlcmd.pl
/usr/share/sqlninja/test.pl
/usr/share/sqlninja/upload.pl
/usr/share/sqlninja/utils.pl

The non standard requres are in following RPMs:
alliance-5.1.1-28.20160506gitd8c05cd.fc38.src.rpm
amanda-3.5.2-2.fc38.src.rpm
atlas-3.10.3-20.fc37.src.rpm
belle-sip-1.4.2-17.fc38.src.rpm
ceph-16.2.11-1.fc36.src.rpm
ceph-17.2.5-11.fc38.src.rpm
cjson-1.7.14-7.fc38.src.rpm
dyninst-12.2.0-2.fc38.src.rpm
fann-2.2.0-27.fc38.src.rpm
garmintools-0.10-25.fc38.src.rpm
ghc-9.2.6-129.fc38.src.rpm
ghc9.0-9.0.2-13.fc38.src.rpm
ghc9.2-9.2.5-15.fc38.src.rpm
ghc9.4-9.4.4-15.fc38.src.rpm
ghc9.6-9.6.0.20230128-2.fc38.src.rpm
glusterfs-10.3-1.fc36.src.rpm
glusterfs-11.0-1.fc38.src.rpm
gnome-keyring-42.1-1.fc36.src.rpm
gnome-keyring-42.1-3.fc38.src.rpm
graphviz-2.50.0-6.fc36.src.rpm
graphviz-7.1.0-2.fc38.src.rpm
grass-8.2.1-1.fc38.src.rpm
gsequencer-4.4.2-1.fc38.src.rpm
hylafax+-7.0.7-1.fc38.src.rpm
ipmctl-03.00.00.0468-2.fc38.src.rpm
kata-containers-3.0.1-1.fc38.1.src.rpm
kdelibs3-3.5.10-120.fc38.src.rpm
kdepimlibs-4.14.10-42.fc38.src.rpm
krb5-1.20.1-8.fc38.src.rpm
kronosnet-1.25-2.fc38.src.rpm
libebml-1.4.4-2.fc38.src.rpm
libesedb-20181229-11.fc38.src.rpm
libiscsi-1.19.0-5.fc36.src.rpm
libiscsi-1.19.0-7.fc38.src.rpm
libmatroska-1.7.1-2.fc38.src.rpm
libvirt-cim-0.6.3-20.fc38.src.rpm
lightsquid-1.8-32.fc38.src.rpm
lxc-4.0.12-2.fc37.src.rpm
mod_nss-1.0.17-16.fc38.src.rpm
mpibash-1.3-15.fc38.src.rpm
mptcpd-0.11-2.fc38.src.rpm
mupen64plus-2.5-17.fc38.src.rpm
nco-5.1.4-1.fc38.src.rpm
netatalk-3.1.14-2.fc38.src.rpm
netcdf-cxx-4.2-31.fc38.src.rpm
openelp-0.9.2-7.fc38.src.rpm
openni-primesense-5.1.6.6-22.fc37.src.rpm
opentrep-0.07.11-5.fc38.src.rpm
pluto-0-0.16gitc6cab36.fc36.src.rpm
portmidi-217-51.fc38.src.rpm
qt3-3.3.8b-94.fc38.src.rpm
recoll-1.34.3-1.fc38.src.rpm
resource-agents-4.12.0-1.fc38.src.rpm
root-6.26.10-5.fc38.src.rpm
rt-5.0.3-4.fc38.src.rpm
sblim-cmpi-base-1.6.4-22.fc38.src.rpm
sblim-cmpi-fsvol-1.5.1-32.fc38.src.rpm
sblim-cmpi-network-1.4.0-31.fc38.src.rpm
sblim-cmpi-nfsv3-1.1.1-28.fc38.src.rpm
sblim-cmpi-nfsv4-1.1.0-30.fc38.src.rpm
sblim-cmpi-rpm-1.0.1-34.fc38.src.rpm
sblim-cmpi-sysfs-1.2.0-30.fc38.src.rpm
sblim-cmpi-syslog-0.9.0-23.fc38.src.rpm
scalasca-2.6.1-2.fc38.src.rpm
sng-1.1.0-16.fc38.src.rpm
sqliteodbc-0.9996-13.fc38.src.rpm
sqlninja-0.2.999-0.19.alpha1.fc38.src.rpm
swift-lang-5.7.3-2.fc38.src.rpm
tclx-8.4.0-42.fc38.src.rpm
terminus-fonts-4.49.1-21.fc38.src.rpm
tix-8.4.3-36.fc38.src.rpm
tog-pegasus-2.14.1-69.fc38.src.rpm
uim-1.8.9-4.fc38.src.rpm
usbguard-1.1.0-6.fc38.src.rpm
wine-8.2-1.fc38.src.rpm
xrdp-0.9.21-2.fc38.src.rpm
yaz-5.34.0-2.fc38.src.rpm

Comment 6 Fedora Release Engineering 2023-08-16 07:10:16 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.