Bug 2173095

Summary: Review Request: rust-heapless - Static friendly data structures that don't require dynamic memory allocation
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/heapless
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-02-27 01:45:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2173094    
Bug Blocks: 2173096    

Description Michel Lind 2023-02-23 22:13:02 UTC
Spec URL: https://salimma.fedorapeople.org/rust-heapless.spec
SRPM URL: https://salimma.fedorapeople.org/rust-heapless-0.7.16-1.fc37.src.rpm

Description:
`static` friendly data structures that don't require dynamic memory
allocation.

Fedora Account System Username: salimma

Comment 1 Jakub Kadlčík 2023-02-23 22:16:00 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5561849
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173095-rust-heapless/fedora-rawhide-x86_64/05561849-rust-heapless/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Davide Cavalca 2023-02-24 17:33:46 UTC
Do you actually need the __trybuild feature? That doesn't look like something we should ship.

Comment 3 Michel Lind 2023-02-24 21:06:05 UTC
Probably not. Disabled that and also the defmt features since defmt does not seem stable enough to package

Comment 4 Davide Cavalca 2023-02-24 21:30:55 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2023-02-24 21:35:19 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-heapless

Comment 6 Fedora Update System 2023-02-25 23:05:20 UTC
FEDORA-2023-98ad341df8 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-98ad341df8

Comment 7 Fedora Update System 2023-02-25 23:08:35 UTC
FEDORA-2023-c100b44172 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c100b44172

Comment 8 Fedora Update System 2023-02-26 00:31:13 UTC
FEDORA-2023-f0c2d69ebd has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f0c2d69ebd

Comment 9 Fedora Update System 2023-02-26 02:01:32 UTC
FEDORA-2023-98ad341df8 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-98ad341df8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-02-26 02:02:39 UTC
FEDORA-2023-c100b44172 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c100b44172`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c100b44172

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-02-27 01:45:14 UTC
FEDORA-2023-c100b44172 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-02-27 02:53:17 UTC
FEDORA-2023-f0c2d69ebd has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2023-03-11 03:07:43 UTC
FEDORA-2023-98ad341df8 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.