Bug 2173174

Summary:	dino: Build in C89 mode due to Vala compiler limitations
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	dino	Assignee:	Florian Weimer <fweimer>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	36	CC:	randy
Target Milestone:	---	Flags:	fweimer: mirror+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	dino-0.4.0-2.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-02-24 14:03:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2137516

Description Florian Weimer 2023-02-24 13:50:30 UTC

This package uses Vala in such a way that the generated C code is not C99-compatible.

C99 compatibility of internal setters
<https://discourse.gnome.org/t/c99-compatibility-of-internal-setters/13360>

valac does not respect internal header/vapi setting
<https://gitlab.gnome.org/GNOME/vala/-/issues/358>

We need to build in C89 mode instead.

Comment 1 Randy Barlow 2023-02-26 16:32:21 UTC

Thanks for the fix Florian!