Bug 2173261

Summary: Review Request: rust-reedline - Readline-like crate for CLI text input
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, decathorpe, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/reedline
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-02-27 01:45:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michel Lind 2023-02-25 03:37:03 UTC
Spec URL: https://salimma.fedorapeople.org/rust-reedline.spec
SRPM URL: https://salimma.fedorapeople.org/rust-reedline-0.16.0-1.fc37.src.rpm

Description:
A readline-like crate for CLI text input.

Fedora Account System Username: salimma

Comment 1 Jakub Kadlčík 2023-02-25 03:40:44 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5565502
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173261-rust-reedline/fedora-rawhide-x86_64/05565502-rust-reedline/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Davide Cavalca 2023-02-25 16:16:42 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2023-02-25 21:22:11 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-reedline

Comment 4 Fedora Update System 2023-02-25 23:05:31 UTC
FEDORA-2023-98ad341df8 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-98ad341df8

Comment 5 Fedora Update System 2023-02-25 23:08:45 UTC
FEDORA-2023-c100b44172 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c100b44172

Comment 6 Fedora Update System 2023-02-26 00:31:24 UTC
FEDORA-2023-f0c2d69ebd has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f0c2d69ebd

Comment 7 Fedora Update System 2023-02-26 02:01:40 UTC
FEDORA-2023-98ad341df8 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-98ad341df8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-02-26 02:02:47 UTC
FEDORA-2023-c100b44172 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c100b44172`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c100b44172

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-02-27 01:45:24 UTC
FEDORA-2023-c100b44172 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2023-02-27 02:53:24 UTC
FEDORA-2023-f0c2d69ebd has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fabio Valentini 2023-03-07 16:01:37 UTC
(In reply to Davide Cavalca from comment #2)
> Package was generated with rust2rpm, simplifying the review.
> 
> - package builds and installs without errors on rawhide
> - test suite is run and all unit tests pass
> - latest version of the crate is packaged
> - license matches upstream specification and is acceptable for Fedora
> - license file is included with %license in %files
> - package complies with Rust Packaging Guidelines
> 
> Package APPROVED.

Please actually check items from this checklist.
The package does *not* install without errors:

https://bugzilla.redhat.com/show_bug.cgi?id=2173419
https://bugzilla.redhat.com/show_bug.cgi?id=2173537
https://bugzilla.redhat.com/show_bug.cgi?id=2173538

I am currently working on updating rusqlite to v0.28, which will fix part of the issue.
The other missing dependency (the "clipboard" crate) has been retired from Fedora 37+.

Comment 12 Fedora Update System 2023-03-11 03:07:52 UTC
FEDORA-2023-98ad341df8 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.