Bug 2173503

Summary: [ovs bond]create bond port failed but reture code is 0
Product: Red Hat Enterprise Linux Fast Datapath Reporter: mhou <mhou>
Component: openvswitch3.1Assignee: Adrián Moreno <amorenoz>
Status: CLOSED EOL QA Contact: mhou <mhou>
Severity: medium Docs Contact:
Priority: unspecified    
Version: FDP 23.BCC: ctrautma, fleitner, jhsiao, kzhang, ralongi
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-10-08 17:49:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description mhou 2023-02-27 06:54:17 UTC
Description of problem:
when create a ovs bond port failed, check the return code of the create command is 0.

Version-Release number of selected component (if applicable):
kernel version:5.14.0-277.el9.x86_64
openvswitch version:
openvswitch-selinux-extra-policy-1.0-31.el9fdp.noarch
openvswitch3.1-3.1.0-2.el9fdp.x86_64
python3-openvswitch3.1-3.1.0-2.el9fdp.x86_64
openvswitch3.1-test-3.1.0-2.el9fdp.noarch


How reproducible: 100%


Steps to Reproduce:
1. run below script
rmmod vfio_iommu_type1
rmmod vfio_pci
rmmod vfio_pci_core
systemctl restart openvswitch
ovs-appctl vlog/set console:lacp:dbg syslog:lacp:dbg file:lacp:dbg
ovs-appctl vlog/set console:bond:dbg syslog:bond:dbg file:bond:dbg
ovs-appctl vlog/set console:ovs_rcu:dbg syslog:ovs_rcu:dbg file:ovs_rcu:dbg
ovs-appctl vlog/set console:memory:dbg syslog:memory:dbg file:memory:dbg
ovs-vsctl set Open_vSwitch . other_config={}
ovs-vsctl --no-wait set Open_vSwitch . other_config:dpdk-socket-mem='8192,8192'
ovs-vsctl --no-wait set Open_vSwitch . other_config:dpdk-lcore-mask=0x800000000
ovs-vsctl --no-wait set Open_vSwitch . other_config:pmd-cpu-mask=0xf000000000
ovs-vsctl --no-wait set Open_vSwitch . other_config:vhost-iommu-support=true
ovs-vsctl --no-wait set Open_vSwitch . other_config:dpdk-init=true
driverctl list-overrides | grep '0000:af:00.1 vfio-pci' &>/dev/null || driverctl set-override 0000:af:00.1 vfio-pci
driverctl list-overrides | grep '0000:af:00.0 vfio-pci' &>/dev/null || driverctl set-override 0000:af:00.0 vfio-pci
driverctl -v list-overrides
ovs-vsctl --if-exists del-br bondbridg
ovs-vsctl --may-exist add-br bondbridge -- set bridge bondbridge datapath_type=netdev
ovs-vsctl set int bondbridge mtu_request=9200
ovs-ofctl mod-port bondbridge bondbridge up
ovs-vsctl add-bond bondbridge active-backup ens4f1 ens4f0 lacp=passive bond_mode=active-backup  -- set Interface ens4f1 type=dpdk options:dpdk-devargs=0000:af:00.1 options:n_rxq=4 options:mtu_request=9200  -- set Interface ens4f0 type=dpdk options:dpdk-devargs=0000:af:00.0 options:n_rxq=4 options:mtu_request=9200  
echo $?

Actual results:
# ovs-vsctl add-bond bondbridge active-backup ens4f1 ens4f0 lacp=passive bond_mode=active-backup  -- set Interface ens4f1 type=dpdk options:dpdk-devargs=0000:af:00.1 options:n_rxq=4 options:mtu_request=9200  -- set Interface ens4f0 type=dpdk options:dpdk-devargs=0000:af:00.0 options:n_rxq=4 options:mtu_request=9200
ovs-vsctl: Error detected while setting up 'ens4f1': Error attaching device '0000:af:00.1' to DPDK.  See ovs-vswitchd log for details.
ovs-vsctl: Error detected while setting up 'ens4f0': Error attaching device '0000:af:00.0' to DPDK.  See ovs-vswitchd log for details.
ovs-vsctl: The default log directory is "/var/log/openvswitch".
# echo $?
0

Expected results:
after create failed, the exit status should not equal 0

Additional info:

Comment 1 Flavio Leitner 2024-03-11 18:59:07 UTC
This could be fixed by https://www.mail-archive.com/ovs-dev@openvswitch.org/msg77869.html
---8<---
[ovs-dev] [PATCH v3] ovs-vsctl: Exit with error if postdb checks report errors.
---8<---
fbl

Comment 2 ovs-bot 2024-10-08 17:49:14 UTC
This bug did not meet the criteria for automatic migration and is being closed.
If the issue remains, please open a new ticket in https://issues.redhat.com/browse/FDP