Bug 2173938

Summary: Fix more FD leaks please.
Product: Red Hat Enterprise Linux 9 Reporter: Robin Hack <rhack>
Component: tunedAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED ERRATA QA Contact: Robin Hack <rhack>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.2CC: jeder, jskarvad
Target Milestone: rcKeywords: AutoVerified, Patch, TestCaseProvided, Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tuned-2.21.0-0.1.rc1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-07 08:56:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Robin Hack 2023-02-28 13:21:15 UTC
Description of problem:
During testing of:
https://bugzilla.redhat.com/show_bug.cgi?id=2080227#c9

everything seemed to be ok. However, some time passed and it look like there is another fd leak on horizon.


Version-Release number of selected component (if applicable):
rhel8 and rhel9 packages seems to be affected.
tuned-2.20.0-1.el8.noarch and same for rhel9.

How reproducible:
Use test.

Steps to Reproduce:
1. use test
2. look at results
3. decide if pass/fail?

Actual results:

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Setup
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

tuned-2.20.0-1.el8.noarch
:: [ 08:11:43 ] :: [   PASS   ] :: Checking for the presence of tuned rpm
:: [ 08:11:43 ] :: [   LOG    ] :: Package versions:
:: [ 08:11:43 ] :: [   LOG    ] ::   tuned-2.20.0-1.el8.noarch
:: [ 08:11:43 ] :: [  BEGIN   ] :: Creating tmp directory :: actually running 'TmpDir=$(mktemp -d)'
:: [ 08:11:43 ] :: [   PASS   ] :: Creating tmp directory (Expected 0, got 0)
:: [ 08:11:43 ] :: [  BEGIN   ] :: Running 'pushd /tmp/tmp.S3leVqTDrA'
/tmp/tmp.S3leVqTDrA /mnt/tests/CoreOS/tuned/Regression/FD-leak-limiting-the-ability-to-switch-the-profile
:: [ 08:11:43 ] :: [   PASS   ] :: Command 'pushd /tmp/tmp.S3leVqTDrA' (Expected 0, got 0)
Redirecting to /bin/systemctl status tuned.service
:: [ 08:11:43 ] :: [   LOG    ] :: rlServiceStart: Service tuned already running, stopping first.
Redirecting to /bin/systemctl stop tuned.service
Redirecting to /bin/systemctl start tuned.service
:: [ 08:11:44 ] :: [   LOG    ] :: rlServiceStart: Service tuned started successfully
:: [ 08:11:44 ] :: [   INFO   ] :: rlImport: Found 'tuned/basic', version '1.0-9' in /mnt/tests
:: [ 08:11:44 ] :: [   INFO   ] :: rlImport: Will try to import tuned/basic from /mnt/tests/CoreOS/tuned/Library/basic/lib.sh
:: [ 08:11:44 ] :: [   INFO   ] :: found dependencies: ''
:: [ 08:11:45 ] :: [   LOG    ] :: Profile 'virtual-guest' was backuped.
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Duration: 2s
::   Assertions: 3 good, 0 bad
::   RESULT: PASS (Setup)


::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Test
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [ 08:11:45 ] :: [  BEGIN   ] :: Running 'tuned-adm profile virtual-guest'
:: [ 08:11:47 ] :: [   PASS   ] :: Command 'tuned-adm profile virtual-guest' (Expected 0, got 0)
:: [ 08:11:47 ] :: [  BEGIN   ] :: Running 'tuned-adm profile accelerator-performance'
:: [ 08:11:49 ] :: [   PASS   ] :: Command 'tuned-adm profile accelerator-performance' (Expected 0, got 0)
:: [ 08:11:49 ] :: [   FAIL   ] :: Seems like leaking FDs! Count: 3
:: [ 08:11:49 ] :: [  BEGIN   ] :: Running 'tuned-adm profile accelerator-performance'
:: [ 08:11:51 ] :: [   PASS   ] :: Command 'tuned-adm profile accelerator-performance' (Expected 0, got 0)
:: [ 08:11:51 ] :: [   FAIL   ] :: Seems like leaking FDs! Count: 4
:: [ 08:11:51 ] :: [  BEGIN   ] :: Running 'tuned-adm profile accelerator-performance'
:: [ 08:11:53 ] :: [   PASS   ] :: Command 'tuned-adm profile accelerator-performance' (Expected 0, got 0)
:: [ 08:11:53 ] :: [   FAIL   ] :: Seems like leaking FDs! Count: 5
:: [ 08:11:53 ] :: [  BEGIN   ] :: Running 'tuned-adm profile accelerator-performance'
:: [ 08:11:55 ] :: [   PASS   ] :: Command 'tuned-adm profile accelerator-performance' (Expected 0, got 0)
:: [ 08:11:55 ] :: [   FAIL   ] :: Seems like leaking FDs! Count: 6
:: [ 08:11:55 ] :: [  BEGIN   ] :: Running 'tuned-adm profile accelerator-performance'
:: [ 08:11:57 ] :: [   PASS   ] :: Command 'tuned-adm profile accelerator-performance' (Expected 0, got 0)
:: [ 08:11:57 ] :: [   FAIL   ] :: Seems like leaking FDs! Count: 7
:: [ 08:11:57 ] :: [  BEGIN   ] :: Running 'tuned-adm profile accelerator-performance'
:: [ 08:11:59 ] :: [   PASS   ] :: Command 'tuned-adm profile accelerator-performance' (Expected 0, got 0)
:: [ 08:11:59 ] :: [   FAIL   ] :: Seems like leaking FDs! Count: 8
:: [ 08:11:59 ] :: [  BEGIN   ] :: Running 'tuned-adm profile accelerator-performance'
:: [ 08:12:02 ] :: [   PASS   ] :: Command 'tuned-adm profile accelerator-performance' (Expected 0, got 0)
:: [ 08:12:02 ] :: [   FAIL   ] :: Seems like leaking FDs! Count: 9
:: [ 08:12:02 ] :: [  BEGIN   ] :: Running 'tuned-adm profile accelerator-performance'
:: [ 08:12:04 ] :: [   PASS   ] :: Command 'tuned-adm profile accelerator-performance' (Expected 0, got 0)
:: [ 08:12:04 ] :: [   FAIL   ] :: Seems like leaking FDs! Count: 10
:: [ 08:12:04 ] :: [  BEGIN   ] :: Running 'tuned-adm profile accelerator-performance'
:: [ 08:12:04 ] :: [   FAIL   ] :: Seems like leaking FDs! Count: 10
:: [ 08:12:06 ] :: [   PASS   ] :: Command 'tuned-adm profile accelerator-performance' (Expected 0, got 0)
:: [ 08:12:06 ] :: [   FAIL   ] :: Seems like leaking FDs! Count: 11
:: [ 08:12:08 ] :: [   PASS   ] :: Command 'tuned-adm profile accelerator-performance' (Expected 0, got 0)
:: [ 08:12:08 ] :: [   FAIL   ] :: Seems like leaking FDs! Count: 12
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Duration: 23s
::   Assertions: 11 good, 10 bad
::   RESULT: FAIL (Test)


::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Cleanup
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [ 08:12:08 ] :: [   PASS   ] :: Command 'popd' (Expected 0, got 0)
:: [ 08:12:08 ] :: [   PASS   ] :: Removing tmp directory (Expected 0, got 0)
:: [ 08:12:10 ] :: [   LOG    ] :: Profile 'virtual-guest' was restored.
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Duration: 4s
::   Assertions: 2 good, 0 bad
::   RESULT: PASS (Cleanup)


::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   /CoreOS/tuned/Regression/FD-leak-limiting-the-ability-to-switch-the-profile
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [ 08:12:12 ] :: [   LOG    ] :: Phases fingerprint:  tIGqJLIX
:: [ 08:12:12 ] :: [   LOG    ] :: Asserts fingerprint: fFB9gcKv
:: [ 08:12:12 ] :: [   LOG    ] :: File '/var/tmp/beakerlib-4132001/journal.xml' stored here: /var/tmp/BEAKERLIB_4132001_STORED_journal.xml
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Duration: 29s
::   Phases: 2 good, 1 bad
::   OVERALL RESULT: FAIL (/CoreOS/tuned/Regression/FD-leak-limiting-the-ability-to-switch-the-profile)



Expected results:
no fd leaks


Additional info:

Comment 1 Jaroslav Škarvada 2023-02-28 16:09:00 UTC
Upstream PR:
https://github.com/redhat-performance/tuned/pull/512

Comment 12 errata-xmlrpc 2023-11-07 08:56:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (tuned bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:6703