Bug 2174723

+++ This bug was initially created as a clone of Bug #2167964 +++

rpmbuild fails with Recognition of file "/builddir/build/BUILDROOT/firefox-109.0.1-2.fc38.x86_64/usr/lib64/firefox/libxul.so" failed:

Processing files: firefox-109.0.1-2.fc38.x86_64
warning: Duplicate build-ids /builddir/build/BUILDROOT/firefox-109.0.1-2.fc38.x86_64/usr/lib64/firefox/firefox and /builddir/build/BUILDROOT/firefox-109.0.1-2.fc38.x86_64/usr/lib64/firefox/firefox-bin
warning: absolute symlink: /usr/lib64/firefox/dictionaries -> /usr/share/hunspell
error: Recognition of file "/builddir/build/BUILDROOT/firefox-109.0.1-2.fc38.x86_64/usr/lib64/firefox/libxul.so" failed: mode 100755 , dynamically linked, BuildID[sha1]=01de62e9e035fb4a7d8effece9283f8746e27dad Note section size too big (124669428 > 67108864) (Invalid argument)

full log:
https://kojipkgs.fedoraproject.org//work/tasks/7865/97227865/build.log

--- Additional comment from Panu Matilainen on 2023-02-08 06:45:36 UTC ---

> Note section size too big (124669428 > 67108864) (Invalid argument)

That's a newish sanity check in libmagic tripping up, added in https://github.com/file/file/commit/e1233247bbe4d2d66b891224336a23384a93cce1

The commit message says to limit to 128M but the limit added in the code is 64M :-/

--- Additional comment from Mark Wielaard on 2023-02-08 14:21:52 UTC ---

(In reply to Panu Matilainen from comment #1)
> > Note section size too big (124669428 > 67108864) (Invalid argument)
> 
> That's a newish sanity check in libmagic tripping up, added in
> https://github.com/file/file/commit/e1233247bbe4d2d66b891224336a23384a93cce1
> 
> The commit message says to limit to 128M but the limit added in the code is
> 64M :-/

Do we know why the notes section is so darn large in the first place?

Adding nickc to the CC because I suspect this might be annobin (if not, sorry Nick).

This is also related to this debugedit bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1609013
[RFE] find-debuginfo.sh should use a reliable, dedicated ELF file id tool, not rely on parsing 'file' output
We have the elfutils eu-elfclassify tool, which probably is more approriate than using file.

--- Additional comment from Nick Clifton on 2023-02-08 16:04:36 UTC ---

(In reply to Mark Wielaard from comment #2)
> (In reply to Panu Matilainen from comment #1)
 
> Do we know why the notes section is so darn large in the first place?
> 
> Adding nickc to the CC because I suspect this might be annobin (if not,
> sorry Nick).
 
Oh - it almost certainly is annobin's fault.  As noted in this PR:

https://sourceware.org/bugzilla/show_bug.cgi?id=29993

The annobin notes in libxul.so are ~118MB.  (This is before they are processed
by objcopy to remove duplicates, and before they are shifted into the associated
debuginfo file).

I am not sure if this helps you though.  If necessary it is possible to build
things with annobin disabled, although I would not actually recommend it unless
there is no other solution.

--- Additional comment from Eike Rathke on 2023-02-09 14:51:15 UTC ---

Fix seems to be on the way with https://src.fedoraproject.org/rpms/file/pull-request/22

Not sure if 128MB is future proof, it's still quite near that Firefox 118.9MB, and Thunderbird even 122.3MB ...

--- Additional comment from Fedora Update System on 2023-02-09 16:54:24 UTC ---

FEDORA-2023-eeda237137 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-eeda237137

--- Additional comment from Fedora Update System on 2023-02-09 21:30:14 UTC ---

FEDORA-2023-eeda237137 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

--- Additional comment from Eike Rathke on 2023-02-09 22:00:28 UTC ---

That should go into f38 as well, please.

--- Additional comment from Eike Rathke on 2023-02-11 16:16:11 UTC ---

Submitted https://src.fedoraproject.org/rpms/file/pull-request/23

--- Additional comment from Fedora Update System on 2023-02-13 17:26:00 UTC ---

FEDORA-2023-a98e46d6c3 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a98e46d6c3

--- Additional comment from Fedora Update System on 2023-02-13 18:09:15 UTC ---

FEDORA-2023-a98e46d6c3 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

--- Additional comment from Lukáš Zaoral on 2023-02-21 14:31:55 UTC ---

This is still present in recent builds of mame even with the recent fix:

error: Recognition of file "/builddir/build/BUILDROOT/mame-0.251-3.fc39.x86_64/usr/bin/mame" failed: mode 100755 , dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=4cb9f6821033586b869d516b865fa1d8e7b8b5f9, for GNU/Linux 3.2.0 Note section size too big (137005660 > 134217728) (Invalid argument)

--- Additional comment from Julian Sikorski on 2023-02-22 20:20:15 UTC ---

Example of failing build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=97870540