Bug 2175160

Summary: Backport fix to BPF fib helper
Product: Red Hat Enterprise Linux 8 Reporter: Toke Høiland-Jørgensen <thoiland>
Component: kernelAssignee: Yauheni Kaliuta <ykaliuta>
kernel sub component: BPF QA Contact: Jean-Tsung Hsiao <jhsiao>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: ctrautma, jbenc, jhsiao, thoiland, ykaliuta, zsun
Version: 8.9Keywords: Triaged
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kernel-4.18.0-491.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-14 15:41:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Toke Høiland-Jørgensen 2023-03-03 12:02:06 UTC
The following upstream commit contains a fix to the bpf_fib_lookup() helper which we have backported to RHEL8:

1fe4850b34ab ("bpf: bpf_fib_lookup should not return neigh in NUD_FAILED state")

The commit is missing a Fixes tag, so it will probably not be picked up by our regular searches, so opening this bug to make sure we include it.

Comment 4 Jon Trossbach 2023-05-02 12:56:49 UTC
sanity tests:
mlx5-cx5 https://beaker.engineering.redhat.com/jobs/7789495
mlx5-cx6 https://beaker.engineering.redhat.com/jobs/7789561
i40e     https://beaker.engineering.redhat.com/jobs/7789496
ice      https://beaker.engineering.redhat.com/jobs/7789567
ixgbe    https://beaker.engineering.redhat.com/jobs/7792436
nfp      https://beaker.engineering.redhat.com/jobs/7792436
mlx4_en  https://beaker.engineering.redhat.com/jobs/7792459
sfc      https://beaker.engineering.redhat.com/jobs/7792463
bnxt_en  https://beaker.engineering.redhat.com/jobs/7803487
qede     https://beaker.engineering.redhat.com/jobs/7804949

xdp_tools:
mlx5-cx5 https://beaker.engineering.redhat.com/jobs/7789568
mlx5-cx6 https://beaker.engineering.redhat.com/jobs/7789570
i40e     https://beaker.engineering.redhat.com/jobs/7789569
ice      https://beaker.engineering.redhat.com/jobs/7789571
ixgbe    https://beaker.engineering.redhat.com/jobs/7793006
nfp      https://beaker.engineering.redhat.com/jobs/7792992
sfc      https://beaker.engineering.redhat.com/jobs/7792999
qede     https://beaker.engineering.redhat.com/jobs/7805036

af_xdp:
mlx5-cx5 https://beaker.engineering.redhat.com/jobs/7789572
mlx5-cx6 https://beaker.engineering.redhat.com/jobs/7789574
i40e     https://beaker.engineering.redhat.com/jobs/7789573
ice      https://beaker.engineering.redhat.com/jobs/7789575
ixgbe    https://beaker.engineering.redhat.com/jobs/7793009

l4lb and offload:
nfp      https://beaker.engineering.redhat.com/jobs/7651567 https://beaker.engineering.redhat.com/jobs/7651569

bpftool: 
mlx5-cx5 https://beaker.engineering.redhat.com/jobs/7805374
mlx5-cx6 https://beaker.engineering.redhat.com/jobs/7805375
i40e     https://beaker.engineering.redhat.com/jobs/7805376
ice      https://beaker.engineering.redhat.com/jobs/7805383
ixgbe    https://beaker.engineering.redhat.com/jobs/7805366
nfp      https://beaker.engineering.redhat.com/jobs/7792998
sfc      https://beaker.engineering.redhat.com/jobs/7793000

iproute2_load_xdp:
mlx5-cx5 https://beaker.engineering.redhat.com/jobs/7805275
mlx5-cx6 https://beaker.engineering.redhat.com/jobs/7805278
i40e     https://beaker.engineering.redhat.com/jobs/7805277
ice      https://beaker.engineering.redhat.com/jobs/7805279
ixgbe    https://beaker.engineering.redhat.com/jobs/7805281
nfp      https://beaker.engineering.redhat.com/jobs/7805282
mlx4_en  https://beaker.engineering.redhat.com/jobs/7807536
sfc      https://beaker.engineering.redhat.com/jobs/7805280
bnxt_en  https://beaker.engineering.redhat.com/jobs/7805259
qede     https://beaker.engineering.redhat.com/jobs/7805417

bcctools:
the below tests fails on  ebpf-xdp-test-tcpdrop  but this seems to be happening independent of this MR
i40e     https://beaker.engineering.redhat.com/jobs/7805363
nfp      https://beaker.engineering.redhat.com/jobs/7792997

Comment 10 Jean-Tsung Hsiao 2023-05-30 15:07:53 UTC
Hi Toke,
I want to verify this bug. So, is there a repro procedure for the verification? Or, a sanity test is enough?
BTW, I can't reach you via Slack ? Have an account ?
Thanks!
Jean

Comment 11 Toke Høiland-Jørgensen 2023-05-31 06:51:43 UTC
(In reply to Jean-Tsung Hsiao from comment #10)
> Hi Toke,
> I want to verify this bug. So, is there a repro procedure for the
> verification? Or, a sanity test is enough?
> BTW, I can't reach you via Slack ? Have an account ?
> Thanks!
> Jean

I don't think we have a reproducer for the original issue fixed by this commit, so doing a sanity check that it doesn't break anything should be fine :)

Comment 14 Jean-Tsung Hsiao 2023-06-02 21:54:27 UTC
Kernel used for comment 13:
[root@netqe1 ~]# uname -r
4.18.0-494.el8.x86_64
[root@netqe1 ~]#

Comment 17 errata-xmlrpc 2023-11-14 15:41:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: kernel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:7077