Bug 217524

Summary:	Review Request: libsyncml - SyncML protocol library
Product:	[Fedora] Fedora	Reporter:	Laurent Rineau <laurent.rineau__fedora>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-11-28 17:47:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Laurent Rineau 2006-11-28 13:28:05 UTC

Spec URL: http://www-sop.inria.fr/geometrica/team/Laurent.Rineau/Fedora/libsyncml.spec
SRPM URL: http://www-sop.inria.fr/geometrica/team/Laurent.Rineau/Fedora/libsyncml-0.4.2-1.src.rpm
Description: 
Libsyncml is a implementation of the SyncML protocol.

Quote from Wikipedia: "SyncML is most commonly thought of as a method to synchronize contact and calendar information between some type of handheld device and a computer (personal, or network-based service), such as between a mobile phone and a personal computer."

Note 1: This library requires wbxml2, which has been unorphaned. See bug #217180.

Note 2: I have not yet managed to build it with mock, because wbxml2 has not been pushed into rawhide. It was build successfully today. See 
http://buildsys.fedoraproject.org/build-status/job.psp?uid=22503

Note 3: libopensync-plugin-syncml will follow, blocked by bug #217150.

Comment 1 Parag AN(पराग) 2006-11-28 17:16:07 UTC

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPMS.
+ source files match upstream.
66fad49f54e78ce34c1453c62958e037  libsyncml-0.4.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ libsyncml-1.0.pc file present.
+ -devel subpackage exists
+ included
  %post -p /sbin/ldconfig
  %postun -p /sbin/ldconfig
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
APPROVED.

Comment 2 Laurent Rineau 2006-11-28 17:30:34 UTC

(In reply to comment #1)
> + package builds in mock (development i386).

Can you explain how you have used mock? wbxml2 packages are not pushed in FE, 
for now.

Comment 3 Parag AN(पराग) 2006-11-28 17:40:58 UTC

yes. I usually do following trick. 
Just add newly created rpms in your extras repository. I never got to use online
repository. I always created own mock environment locally as its easy for me to
add new rpms and test other packages dependent on this new rpms.

Comment 4 Laurent Rineau 2006-11-28 17:47:42 UTC

Imported and build. Build job 
http://buildsys.fedoraproject.org/build-status/job.psp?uid=22528 successful.