Bug 217566
| Summary: | /lib/lsb/init-functions erroneously uses 'alias' to define lsb compatible init functions | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Bryn M. Reeves <bmr> | ||||||||
| Component: | redhat-lsb | Assignee: | Lawrence Lim <llim> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | David Lawrence <dkl> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 5.0 | CC: | iboverma, mbest, pcormier, tools-bugs | ||||||||
| Target Milestone: | --- | Keywords: | Reopened | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | RHBA-2007-0590 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2007-11-07 18:01:42 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 217570, 218245 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Bryn M. Reeves
2006-11-28 17:33:45 UTC
Created attachment 142310 [details]
convert aliases to functions in /lib/lsb/init-functions
A simple patch is attached that replaces the alias definitions with true
functions. This was tested with /etc/init.d/xendomains and works - this seems
to be the only initscript in RHEL that uses the lsb definitions so this should
be a fairly low-risk change.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. Thanks for the bug report. Patch has been applied and built into redhat-lsb-3.1-12.src.rpm under RHEL5-branch. Thanks - tested with redhat-lsb-3.1-12.1.i386.rpm and now works fine with the stock xendomains script. Fix in redhat-lsb-3.1-12. Shouldn't those shell functions pass arguments down to what they are executing? I.e. have "$@" at the end? Created attachment 142821 [details]
convert aliases to functions in /lib/lsb/init-functions
Yes, they should: revised patch attached with this correction.
Patch revised in redhat-lsb-3.1-12.2.EL. Thanks. *** Bug 218989 has been marked as a duplicate of this bug. *** Hi Lawrence,
we have noticed that one of the functions has a strange name:
+pidofprof () {
+ /etc/redhat-lsb/lsb_pidofproc "$@"
Shouldn't that be pidofproc instead?
Jan
A package has been built which should help the problem described in this bug report. This report is therefore being closed with a resolution of CURRENTRELEASE. You may reopen this bug report if the solution does not work for you. Created attachment 151434 [details]
lsb-aliases_to_funcs.patch
5.1 should be better. I will try to propose. Did we integrate this patch? Not in 5.0 but it will be available in the 5.1 update. *** Bug 230973 has been marked as a duplicate of this bug. *** An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2007-0590.html |