Bug 2175867
| Summary: | Rook sets cephfs kernel mount options even when mon is using v1 port | ||
|---|---|---|---|
| Product: | [Red Hat Storage] Red Hat OpenShift Data Foundation | Reporter: | Malay Kumar parida <mparida> |
| Component: | rook | Assignee: | Travis Nielsen <tnielsen> |
| Status: | CLOSED ERRATA | QA Contact: | Petr Balogh <pbalogh> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.13 | CC: | muagarwa, nberry, ocs-bugs, odf-bz-bot, tnielsen |
| Target Milestone: | --- | ||
| Target Release: | ODF 4.13.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | No Doc Update | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-06-21 15:24:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Malay Kumar parida
2023-03-06 16:51:02 UTC
The ms_mode=prefer-crc for cephfs is set in the storage class so the ocs operator will need to fix this scenario for cephfs. Upgraded clusters should not set this ms_mode setting on the cephfs storageclass. Perhaps the simplest will be to detect if the storage class doesn't exist yet, assume it's a new cluster and generate the storage class with the ms_mode attribute. But if the storage class already exists, don't update it with the ms_mode property. If upgraded clusters want to enable it, we would need to document to add that property. Malay, did you see any issue with rbd volumes after the upgrade? Rook would need to fix that case since the ms_mode for rbd is set by the rook operator. In that case, please open a new BZ for rbd. Let's keep this issue for cephfs in the ocs operator. The options to set the map/mount option work was done one rook side for rbd-https://github.com/rook/rook/pull/11523 for cephfs-https://github.com/rook/rook/pull/11625 So I am not sure if the fix needs to go on ocs or on rook. BTW another question the problem arises because the mon are using the v1 port, even though we set requiremsgr2 true. So I was asking can't we do something so that after upgrade to odf 4.13 the mons start using the msgr v2 port instead of the v1 port. I think that would be a more complete solution as we don't want customers to be left on the v1 port forever. Oh right, the cephfs options were also done in rook, I was thinking they were done in the storageclass. Moving back to rook. I'll take a look while Madhu is out Testing this change: https://github.com/rook/rook/pull/11859 When msgr2 is required, ensure the mon endpoints passed to the csi configmap are on port 3300. The mons will still be listening on both 6789 and 3300 if they were created before msgr2 was required. Existing volumes can continue using port 6789 while new volumes will use port 3300. This fix is merged downstream to 4.13 with https://github.com/red-hat-storage/rook/pull/452 This is expected to fix the issue with cephfs volumes not being created after upgrade from 4.12 to 4.13. Fixed in version: Any latest stable 4.13 build @nberry Yes. Creation of cephfs volumes & mounting them into a pod in an upgraded cluster will suffice our case. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Red Hat OpenShift Data Foundation 4.13.0 enhancement and bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2023:3742 The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days |