Bug 2176356

Summary:	[4.10.z clone] Move the defaults for rookceph operator from configmap to csv
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	Nikhil Ladha <nladha>
Component:	ocs-operator	Assignee:	Nikhil Ladha <nladha>
Status:	CLOSED ERRATA	QA Contact:	Joy John Pinto <jopinto>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.10	CC:	ebenahar, etamir, kramdoss, mparida, nladha, ocs-bugs, odf-bz-bot, rar, sheggodu
Target Milestone:	---
Target Release:	ODF 4.10.12
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	2176012	Environment:
Last Closed:	2023-04-26 17:13:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2176012, 2176357, 2176359
Bug Blocks:

Description Nikhil Ladha 2023-03-08 05:50:28 UTC

+++ This bug was initially created as a clone of Bug #2176012 +++

Description of problem (please be detailed as possible and provide log
snippests):

Currently upgraded cluster do not have CSI_LOG_LEVEL: 5 in rook-ceph-operator-config. 
This leads to csi pods having log level of 0, which makes it very hard to debug. 

Also, CSI_ENABLE_CSIADDONS is false by default and we need to enable it manually.

Both the above issues can be resolved by backporting pr https://github.com/red-hat-storage/ocs-operator/pull/1648 
and moving defaults to csv.

Actual results:
Upgraded cluster do not have necessary defaults.

Expected results:
Upgraded clusters will automatically get these defaults from csv.

Additional info:

N.A

Comment 8 Joy John Pinto 2023-04-06 11:16:36 UTC

Verified on a newly deployed ODF cluster

OCP 4.10.0-0.nightly-2023-04-05-034819 and ODF 4.10.12

      name: rook-ceph-operator
      env:
        - name: ROOK_CURRENT_NAMESPACE_ONLY
          value: 'true'
        - name: ROOK_ALLOW_MULTIPLE_FILESYSTEMS
          value: 'false'
        - name: ROOK_LOG_LEVEL
          value: INFO
        - name: ROOK_CEPH_STATUS_CHECK_INTERVAL
          value: 60s
        - name: ROOK_MON_HEALTHCHECK_INTERVAL
          value: 45s
        - name: ROOK_MON_OUT_TIMEOUT
          value: 600s
        - name: ROOK_DISCOVER_DEVICES_INTERVAL
          value: 60m
        - name: ROOK_HOSTPATH_REQUIRES_PRIVILEGED
          value: 'true'
        - name: ROOK_ENABLE_SELINUX_RELABELING
          value: 'true'
        - name: ROOK_ENABLE_FSGROUP
          value: 'true'
        - name: ROOK_ENABLE_FLEX_DRIVER
          value: 'false'
        - name: ROOK_ENABLE_DISCOVERY_DAEMON
          value: 'false'
        - name: ROOK_ENABLE_MACHINE_DISRUPTION_BUDGET
          value: 'false'
        - name: ROOK_DISABLE_DEVICE_HOTPLUG
          value: 'true'
        - name: ROOK_CSI_ALLOW_UNSUPPORTED_VERSION
          value: 'true'
        - name: CSI_VOLUME_REPLICATION_IMAGE
          value: >-
            quay.io/rhceph-dev/odf4-volume-replication-rhel8-operator@sha256:8af04a12e2e3e3003c39c5dc12f544538caca813d8d912b267d1ff78b70d8c84
        - name: ROOK_CSIADDONS_IMAGE
          value: >-
            quay.io/rhceph-dev/odf4-odf-csi-addons-sidecar-rhel8@sha256:a421ae06be561c3d8cec382d999eb430022ed04f4929abea8d8c0cdd2b0db57b
        - name: CSI_PROVISIONER_TOLERATIONS
          value: |-

            - key: node.ocs.openshift.io/storage
              operator: Equal
              value: "true"
              effect: NoSchedule
        - name: CSI_PLUGIN_TOLERATIONS
          value: |-

            - key: node.ocs.openshift.io/storage
              operator: Equal
              value: "true"
              effect: NoSchedule
        - name: CSI_LOG_LEVEL
          value: '5'
        - name: CSI_ENABLE_CSIADDONS
          value: 'true'

Comment 13 errata-xmlrpc 2023-04-26 17:13:29 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenShift Data Foundation 4.10.12 Bug Fix Update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2032