Bug 2176391

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5613857
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2176391-vcdimager/fedora-rawhide-x86_64/05613857-vcdimager/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Taking this review.

Initial spec review:

> Requires(post):  info
> Requires(preun): info

This is only needed for EL7. EL8 and newer have file triggers so this should be dropped for them.

> find $RPM_BUILD_ROOT -type f -name "*.la" -exec rm -f {} ';'

This should be %{buildroot} for consistency

> %post libs -p /sbin/ldconfig
> %postun libs -p /sbin/ldconfig

This is only needed for EL7. If you want to have EL7 compatibility, please switch to "%ldconfig_scriptlets libs" instead, so it becomes a no-op on EL8+ and Fedora.

> %post
> for infofile in vcdxrip.info vcdimager.info vcd-info.info; do
>   /sbin/install-info %{_infodir}/${infofile} %{_infodir}/dir 2>/dev/null || :
> done
> 
> %preun
> if [ $1 -eq 0 ]; then
>   for infofile in vcdxrip.info vcdimager.info vcd-info.info; do
>     /sbin/install-info --delete %{_infodir}/${infofile} %{_infodir}/dir \
>       2>/dev/null || :
>   done
> fi

This is only needed for EL7. EL8 and newer have file triggers so this should be dropped for them.

> %{_bindir}/*
> %{_mandir}/man1/*

This kind of globbing is not explicit/specific enough, there's no way to tell if the package may add conflicting binaries.

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists

Thanks Neal.

All fixed in :
Spec URL: https://www.bachelot.org/fedora/SPECS/vcdimager.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/vcdimager-2.0.1-15.fc39.src.rpm

Oh I missed one...

> License: GPLv2+

This needs to be "GPL-2.0-or-later" now.

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names

> %{_mandir}/man1/cdxa2mpeg.1.gz
> %{_mandir}/man1/vcd-info.1.gz
> %{_mandir}/man1/vcdimager.1.gz
> %{_mandir}/man1/vcdxbuild.1.gz
> %{_mandir}/man1/vcdxgen.1.gz
> %{_mandir}/man1/vcdxminfo.1.gz
> %{_mandir}/man1/vcdxrip.1.gz

Please use "1*" here, because we don't guarantee gzipped man pages

Created attachment 1949028 [details]
The .spec file difference from Copr build 5613857 to 5614851

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5614851
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2176391-vcdimager/fedora-rawhide-x86_64/05614851-vcdimager/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Fixed License: to use SPDX and manpages to use a glob instead of fixed .gz.


Spec URL: https://www.bachelot.org/fedora/SPECS/vcdimager.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/vcdimager-2.0.1-16.fc39.src.rpm

Created attachment 1949047 [details]
The .spec file difference from Copr build 5614851 to 5614984

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5614984
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2176391-vcdimager/fedora-rawhide-x86_64/05614984-vcdimager/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

This looks great now.

PACKAGE APPROVED.

The Pagure repository was created at https://src.fedoraproject.org/rpms/vcdimager

FEDORA-2023-706a02d681 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-706a02d681

FEDORA-EPEL-2023-967aa197e2 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-967aa197e2

FEDORA-2023-bbd85c941a has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bbd85c941a

FEDORA-2023-0b053c84b8 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0b053c84b8

FEDORA-EPEL-2023-c71897b5ef has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-c71897b5ef

FEDORA-2023-706a02d681 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-EPEL-2023-c71897b5ef has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2023-bbd85c941a has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2023-0b053c84b8 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-EPEL-2023-967aa197e2 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.