Bug 2176725

Summary:	"Start this VirtualMachine after creation" is not carried over to next dialog during VM creation
Product:	Container Native Virtualization (CNV)	Reporter:	Germano Veit Michel <gveitmic>
Component:	User Experience	Assignee:	Hilda Stastna <hstastna>
Status:	CLOSED ERRATA	QA Contact:	Guohua Ouyang <gouyang>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.12.5	CC:	gouyang, hstastna, rsdeor, yfrimanm
Target Milestone:	---
Target Release:	4.13.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-18 02:58:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Germano Veit Michel 2023-03-09 04:15:32 UTC

Description of problem:

User needs to uncheck "Start this VirtualMachine after creation" twice, because after clicking next on the VM customization this option is checked again.

Version-Release number of selected component (if applicable):
CNV 4.12.1 + OCP 4.12.6

How reproducible:
Always

Steps to Reproduce:
1. Create Virtual Machine from catalog
2. Pick an entry from the catalog
3. In the quick create dialog, fill in the name and uncheck "Start this VirtualMachine after creation"
4. Click "Customize VirtualMachine"
5. Click Next
6. Now in the "Review and create VirtualMachine", look at the bottom and see "Start this VirtualMachine after creation" is checked/enabled again.

Actual results:
* "Start this VirtualMachine after creation" not carried over

Expected results:
* Persist the setting when progressing to new dialogs

Comment 1 Hilda Stastna 2023-03-09 16:38:03 UTC

I am not sure if this behavior is not by design - checking "Start this VirtualMachine after creation" by default, when reaching some page containing this checkbox.
WDYT, Yifat? Can you, please, advice? Thanks!

Comment 2 Yifat Menchik 2023-03-09 17:55:05 UTC

I think that if a user decided to unselect something, they probably have a reason for that. They continue with the flow and then realize that the selection they just marked is not kept, so they need to uncheck it again. This doesn’t look like a nice user experience, TMO. I think users would expect their selection to be kept, unless they decide to change it (as long as they didn’t click “create”). @gouyang @rsdeor WDYT?

Comment 3 Guohua Ouyang 2023-03-09 23:26:09 UTC

It should be carried over to next page just like the VM name.

Comment 4 Hilda Stastna 2023-03-10 18:52:15 UTC

Fixing:
https://github.com/kubevirt-ui/kubevirt-plugin/pull/1133

Comment 5 Ronen 2023-03-15 06:55:18 UTC

I agree, user selection should not be override when moving between pages

Comment 6 Guohua Ouyang 2023-03-27 06:59:39 UTC

verified on 4.13.0

Comment 8 errata-xmlrpc 2023-05-18 02:58:16 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.13.0 Images security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:3205