Bug 2176727

Summary: Add ip address field to IP configuration in NNCP create form
Product: Container Native Virtualization (CNV) Reporter: Guohua Ouyang <gouyang>
Component: User ExperienceAssignee: Ugo Palatucci <upalatuc>
Status: VERIFIED --- QA Contact: Guohua Ouyang <gouyang>
Severity: high Docs Contact:
Priority: high    
Version: 4.13.0CC: gouyang, jcall, tnisan, upalatuc, ycui
Target Milestone: ---Flags: gouyang: needinfo? (tnisan)
Target Release: 4.14.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
no field for ip address none

Description Guohua Ouyang 2023-03-09 04:23:05 UTC
Created attachment 1949206 [details]
no field for ip address

Description of problem:
Create NodeNetworkConfigurationPolicy from form, there is no field to fill ip address and subnet for IP configuration, which is not working if the environment has no DHCP configured.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Guohua Ouyang 2023-03-28 03:44:29 UTC
NNCP is not available on d/s test environment, I guess it moved to 4.14.

Tal and Ycui,
Can you confirm?

Comment 3 Guohua Ouyang 2023-04-12 04:01:23 UTC
1. The upstream PR is not included in d/s build, tested with the latest build from here, the problem is still showing: https://brewweb.engineering.redhat.com/brew/packageinfo?packageID=83838 
2. Then I moved the upstream build `quay.io/nmstate/nmstate-console-plugin:latest`, the UI is updated but it still failed to configure the NNCP because prefix-length is missing.

Comment 5 Guohua Ouyang 2023-04-12 04:04:21 UTC
One more issue is the NNCP is not installed along with the deployment, when deploy manually via below script, it disabled the kubevirt-plugin so the Virtualization page is disappeared.


#!/bin/bash

set -ex
oc process -f oc-manifest.yaml \
  -p PLUGIN_NAME=nmstate-console-plugin \
  -p NAMESPACE=openshift-nmstate \
  -p IMAGE=quay.io/nmstate/nmstate-console-plugin:latest \
  | oc create -f -

oc patch consoles.operator.openshift.io cluster \
  --patch '{ "spec": { "plugins": ["nmstate-console-plugin"] } }' --type=merge

Comment 6 Guohua Ouyang 2023-04-12 05:38:16 UTC
(In reply to Guohua Ouyang from comment #5)
> One more issue is the NNCP is not installed along with the deployment, when
> deploy manually via below script, it disabled the kubevirt-plugin so the
> Virtualization page is disappeared.
> 

> oc patch consoles.operator.openshift.io cluster \
>   --patch '{ "spec": { "plugins": ["nmstate-console-plugin"] } }'
> --type=merge

This is the problem, the correct patch should be:
oc patch consoles.operator.openshift.io cluster \
  --patch '{ "spec": { "plugins": ["nmstate-console-plugin", "kubevirt-plugin"] } }' --type=merge

Comment 7 Ugo Palatucci 2023-04-12 08:38:55 UTC
@gouyang seems like we are having issues syncing branches.

I and an art-team member opened a thread to understand what is going on. 

Seems the configuration is a little bit odd

Comment 8 Guohua Ouyang 2023-04-12 08:49:28 UTC
(In reply to Ugo Palatucci from comment #7)
> @gouyang seems like we are having issues syncing branches.
> 
> I and an art-team member opened a thread to understand what is going on. 
> 
> Seems the configuration is a little bit odd

Great and thanks, please keep us posted.
And hope the two issues will be addressed:
1. the builds [https://brewweb.engineering.redhat.com/brew/packageinfo?packageID=83838] should include the fix
2. the plugin should be deployed along with the nmstate operator, currently it seems not, as I could not find any info about the plugin in the YAML of nmstate-operator

Comment 9 Guohua Ouyang 2023-04-18 04:25:52 UTC
Verified the bug with upstream image: quay.io/nmstate/nmstate-console-plugin:latest

Still wait for downstream build to verify the bug

Comment 10 Ying Cui 2023-04-25 08:07:47 UTC
(In reply to Guohua Ouyang from comment #2)
> NNCP is not available on d/s test environment, I guess it moved to 4.14.
> 
> Tal and Ycui,
> Can you confirm?

The bug is not fix in 4.13.0,  it depends on the PR https://github.com/openshift/kubernetes-nmstate/pull/357

Comment 11 Ugo Palatucci 2023-06-07 07:44:35 UTC
The bug target release should be updated to 4.14. 

The PR to integrate the plugin with the nmstate operator for 4.13 has been reverted and we'll skip this version.
We can install the plugin on a 4.13 console UI and works with the nmstate operator, but for 4.13 the operator will still be delivered without the plugin.
The plugin will be available with the operator only on 4.14 at the moment.

Comment 12 Guohua Ouyang 2023-07-14 03:37:35 UTC
verified on kubevirt-console-plugin-rhel9:v4.14.0-2121