Bug 2176791

Summary: rpm license that is a spdx license expression using brackets results in gnome-software categorizing it as Proprietary
Product: [Fedora] Fedora Reporter: Caolan McNamara <caolanm>
Component: appstreamAssignee: Rex Dieter <rdieter>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 37CC: kde-sig, rdieter, tdawson
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-12 23:00:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot of the problem in gnome-software none

Description Caolan McNamara 2023-03-09 10:32:16 UTC 
Created attachment 1949271 [details]
screenshot of the problem in gnome-software

Description of problem:
rpm license that is a spdx license expression using brackets results in gnome-software categorizing it as Proprietary

Version-Release number of selected component (if applicable):
appstream 0.16,101,fc36

How reproducible:
100%

Steps to Reproduce:
1. Install libreoffice
2. LANG=ga_IE.UTF-8 libreoffice
3. this will cause a "Additional Packages Requred" notification to appear, click it to launch gnome-software

Actual results:
1. gnome software will list libreoffice-langpack-ga but it will be marked as "Potentially Unsafe" due to "Propietary code"

Expected results:
That is shown as free software

Additional info:
while "license-validate" is happy with the libreoffice license, appstreamcli is not. Debugging that I think the problem is with the use of brackets in the license expression, triggering appstream to conclude that the license is not a spdx one.

See: https://github.com/ximion/appstream/pull/469 for my stab at a patch to fix this problem.
Comment 1 Aoife Moloney 2023-11-23 01:25:14 UTC 
This message is a reminder that Fedora Linux 37 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 37 on 2023-12-05.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '37'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 37 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.
Comment 2 Aoife Moloney 2024-01-12 23:00:41 UTC 
Fedora Linux 37 entered end-of-life (EOL) status on 2023-12-05.

Fedora Linux 37 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.