Bug 2176797
| Summary: | Make "YAML" button consistent with other pages | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Container Native Virtualization (CNV) | Reporter: | Guohua Ouyang <gouyang> | ||||||||
| Component: | User Experience | Assignee: | Hilda Stastna <hstastna> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Guohua Ouyang <gouyang> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 4.13.0 | CC: | apinnick, gouyang, hstastna, mschatzm, ocohen, tnisan, ycui, yfrimanm | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | 4.14.0 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2023-11-08 14:05:04 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
Note that this bug is more about moving the content of the NICs/Disks tab under new sub-sub-tabs (see the attachment of this BZ), so the YAML could be placed next to them. I don't see anything related to adding sub-titles to those pages, according to the attachment of the BZ, that should represent the expected result, proposed by Yifat. Because we want to keep consistency in the UI, we IMO should do the same (create new sub-sub tabs) also for some other pages: - we have 3 subsections in VM Details tab, - 2 subsections in Scripts tab, - 2 in the new Diagnostics tab Regarding the NICs tab, the expected result is still not clear, as there's a bit different situation than in the Disks tab: we need to deal with the 3 components in the UI: the button to add NIC, the (sub)title of the page and the YAML switcher. Update: the expected results for this BZ are actually under the discussion. Created attachment 1955297 [details]
Disks tab
@hstastna please review the Disks tab example. Thanks.
Created attachment 1955394 [details]
Network interfaces
@hstastna please see the examples I attached for the disks tab and for the network interfaces tab. Thanks. Hi Guohua, can you, please, advice, why the BZ was moved to POST and MODIFIED, if I haven't posted any PR for this BZ yet? I am confused. Not sure, what to do. Thanks a lot! (In reply to Hilda Stastna from comment #7) > Hi Guohua, > > can you, please, advice, why the BZ was moved to POST and MODIFIED, if I > haven't posted any PR for this BZ yet? I am confused. Not sure, what to do. > Thanks a lot! The bug was moved to MODIFIED by the midstream PR #970, and that PR looks has no relation to this bug. @Oren, could you take a look at it and help fix the issue? It happens often and confuse us a lot. It's not the first time to see this problem happen, I've mentioned this to Tal and Ycui long time ago. @Tal @Ycui, We must spend some time to set the CI work properly, there are several issues: 1. cherry-pick does not create bug automatically 2. target-release issue in PR, not able to set the valid-bug label in PR due to the target release not available for z-stream 3. the midstream PR linked to this bug is not relevant 4. when move the bug to post/modified/ON_QA? My opinion are: - the bug is moved to POST once the upstream PR is linked in the bug. - then the bug is moved to MODIFIED once the midstream PR is merged - then the bug is moved to ON_QA once the kubevirt-plugin-console build includes the fix is available Note that the same inconsistency as in VM Disks and NIcs tabs is present also in the Catalog wizard - the same tabs, and so it should be fixed also there. The same for VM Templates Disk and NICs tabs. Also I've found there are many more inconsistencies across those pages, such as title font size etc, presence vs. not presence of the title for those tabs... I think we need another discussion and BZ for that... So Yifat, please, ping me once you'll have time for that. Thanks. Another important note: More than just one PR will be needed to completely fix this BZ, as it requires more changes in more screens. (In reply to Guohua Ouyang from comment #8) > (In reply to Hilda Stastna from comment #7) > > Hi Guohua, > > > > can you, please, advice, why the BZ was moved to POST and MODIFIED, if I > > haven't posted any PR for this BZ yet? I am confused. Not sure, what to do. > > Thanks a lot! > > The bug was moved to MODIFIED by the midstream PR #970, and that PR looks > has no relation to this bug. > @Oren, could you take a look at it and help fix the issue? It happens often > and confuse us a lot. > > It's not the first time to see this problem happen, I've mentioned this to > Tal and Ycui long time ago. > > @Tal @Ycui, We must spend some time to set the CI work properly, there are > several issues: > 1. cherry-pick does not create bug automatically > 2. target-release issue in PR, not able to set the valid-bug label in PR due > to the target release not available for z-stream > 3. the midstream PR linked to this bug is not relevant > 4. when move the bug to post/modified/ON_QA? My opinion are: > - the bug is moved to POST once the upstream PR is linked in the bug. > - then the bug is moved to MODIFIED once the midstream PR is merged > - then the bug is moved to ON_QA once the kubevirt-plugin-console build > includes the fix is available according to the UI scrub meeting, let's start the email to discuss it with team. Thanks. verified on kubevirt-console-plugin-rhel9:v4.14.0-1195 1. the YAML switcher button is moved to the right top, next to Actions button 2. Titles are added to metrics/events/network tab 3. "Disks" is moved to top of "Add disk" button Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: OpenShift Virtualization 4.14.0 Images security and bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:6817 The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days |
Created attachment 1949274 [details] disks tab example Description of problem: This is a follow-up bug of #2173563, to make all pages looking consistently, a subtitle might need to be added to Network interface tabs and disks tab, and the YAML button should be next to it. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: