Bug 2176837

Summary: Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package
Product: [Fedora] Fedora Reporter: Rémi Verschelde <rverschelde>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-03-15 00:17:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Rémi Verschelde 2023-03-09 12:59:05 UTC
Spec URL: https://akien.fedorapeople.org/srpms/godot3.spec
SRPM URL: https://akien.fedorapeople.org/srpms/godot3-3.5.2-1.mga9.src.rpm=
Description: Multi-platform 2D and 3D game engine with a feature-rich editor (version 3)
Fedora Account System Username: akien
Existing `godot` package: https://src.fedoraproject.org/rpms/godot
Diff of changes between godot-3.4.5-4 and godot3-3.5.2-1: https://akien.fedorapeople.org/srpms/godot-to-godot3.diff

This follows bug 1552767 where the `godot` package was approved in 2018, and I'm its current maintainer (as well as upstream project maintainer).

We just released Godot 4.0 as a major, compatibility breaking update, and we would like to provide both versions in parallel to Fedora users, so they can choose to stay on Godot 3.x for their existing projects, or port their projects to Godot 4.x.

So this new package request is basically forking `godot` to `godot3`, with appropriate renames, and updating the package from 3.4.5 to 3.5.2 while at it.

The main `godot` package will be upgraded to 4.0.

Comment 1 Neal Gompa 2023-03-09 13:00:15 UTC
Taking this review.

Comment 2 Neal Gompa 2023-03-09 15:05:16 UTC
This package is effectively a rename, and the diff is concentrated to that.

The package data is comprehensive, follows our guidelines, builds and installs, and otherwise looks good.

PACKAGE APPROVED.

Comment 3 Neal Gompa 2023-03-09 15:06:06 UTC
I did notice that you have a note about bundling wslay because it's not packaged. Can you put up a package review for that so we can unbundle it?

Comment 4 Rémi Verschelde 2023-03-09 15:22:02 UTC
(In reply to Neal Gompa from comment #3)
> I did notice that you have a note about bundling wslay because it's not
> packaged. Can you put up a package review for that so we can unbundle it?

Yes I can :) Here we go: bug 2176889.

Comment 5 Fedora Admin user for bugzilla script actions 2023-03-09 15:30:35 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/godot3

Comment 6 Fedora Update System 2023-03-10 13:08:56 UTC
FEDORA-2023-1dddf8b462 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1dddf8b462

Comment 7 Fedora Update System 2023-03-10 13:13:45 UTC
FEDORA-2023-c2cf0d8528 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c2cf0d8528

Comment 8 Fedora Update System 2023-03-10 13:14:29 UTC
FEDORA-2023-6d3bbb9b6d has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6d3bbb9b6d

Comment 9 Fedora Update System 2023-03-11 04:41:13 UTC
FEDORA-2023-c2cf0d8528 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c2cf0d8528`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c2cf0d8528

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-03-11 05:24:15 UTC
FEDORA-2023-6d3bbb9b6d has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-6d3bbb9b6d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6d3bbb9b6d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-03-11 05:39:02 UTC
FEDORA-2023-1dddf8b462 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-1dddf8b462

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-03-15 00:17:06 UTC
FEDORA-2023-1dddf8b462 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2023-03-16 18:32:20 UTC
FEDORA-2023-6d3bbb9b6d has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2023-03-19 02:04:52 UTC
FEDORA-2023-c2cf0d8528 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.