Bug 2177189

Summary: perl-SDL will fail to build with GCC 14 because of an implicit _calc_offset() declaration
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: perl-SDLAssignee: Petr Pisar <ppisar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fweimer, hdegoede, perl-devel
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/PerlGameDev/SDL/pull/299
Whiteboard:
Fixed In Version: perl-SDL-2.548-17.fc39 perl-SDL-2.548-17.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-03-31 01:33:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2173510    
Bug Blocks: 2137512    

Description Petr Pisar 2023-03-10 10:35:33 UTC
I recommend applying <https://github.com/PerlGameDev/SDL/pull/299> patch to fix building perl-SDL with GCC 14.

Comment 1 Hans de Goede 2023-03-10 11:30:09 UTC
Petr, thank you for the pointer to the fix and also thank you for your work on bug 2173510 (the tests hang).

I could really use a co-maintainer for perl-SDL, shall I add you as a co-maintainer?

If yes, what is your FAS accountname ?

Then you can add the mentioned pull-req as a downstream patch yourself for now and lets also disable the tests (or just the problematic one) for now with a link to the upstream sdl12-compat issue ?

Comment 2 Petr Pisar 2023-03-10 11:58:45 UTC
Yes, please add me as a comaintainer. My account is ppisar.

Comment 3 Hans de Goede 2023-03-10 12:17:25 UTC
(In reply to Petr Pisar from comment #2)
> Yes, please add me as a comaintainer. My account is ppisar.

Done, you are a co-admin of the package now, thank you for your help with this!

Note both for now and for the future if you have any fixes / improvements to commit to the package just go for it.

There is no need to coordinate, I seldomly touch this package so the chances of (git) conflicts are very minimal.

Comment 4 Petr Pisar 2023-03-10 16:44:26 UTC
Thanks. I pushed this fix and other my improvements. I tested them locally. I will build perl-SDL in Koji once sld12-compat is fixed.

Comment 5 Petr Pisar 2023-03-22 15:17:59 UTC
sld12-compat was fixed. perl-SDL is no built. I will also build the fix for F38 because all F38 packages should be rebuilt with F38 toolchain.

Comment 6 Fedora Update System 2023-03-22 15:36:47 UTC
FEDORA-2023-e885399c38 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e885399c38

Comment 7 Fedora Update System 2023-03-23 02:57:01 UTC
FEDORA-2023-e885399c38 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e885399c38

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-03-31 01:33:13 UTC
FEDORA-2023-e885399c38 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.