Bug 2177282

Summary:	sos subscription_manager plugin may collect proxy passwords
Product:	Red Hat Enterprise Linux 8	Reporter:	Stepan Broz <sbroz>
Component:	sos	Assignee:	Pavel Moravec <pmoravec>
Status:	CLOSED ERRATA	QA Contact:	Adriana Jurkechova <ajurkech>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.7	CC:	agk, ajurkech, cww, jcastillo, jjansky, mhradile, plambri, sbradley, theute
Target Milestone:	rc	Keywords:	EasyFix, OtherQA, Patch, Triaged
Target Release:	---	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	sos-4.5.3-1.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-31 18:49:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Stepan Broz 2023-03-10 17:34:59 UTC

Description of problem:
The subscription_manager plugin collects the "/var/lib/rhsm/" path, but on that path a copy of a repository file may exist, which in turn may contain e.g. proxy usernames and passwords.

Version-Release number of selected component (if applicable):
sos-4.3-5.el8.noarch (but upstream is affected too)

How reproducible:
Always

Steps to Reproduce:
1. Edit /var/lib/rhsm/repo_server_val/redhat.repo and add "proxy", "proxy_username", and "proxy_password" to any of the repositories:

proxy=http://proxy.example.com:3128/
proxy_username=foobar
proxy_password=hackme

2. Run the sos report subscription_manager plugin:

    # sos report -o subscription_manager


Actual results:
Collected /var/lib/rhsm/repo_server_val/redhat.repo still contains the password.

Expected results:
The password is scrubbed off.

Additional info:
https://github.com/sosreport/sos/issues/3163
https://github.com/sosreport/sos/pull/3164

Comment 4 Adriana Jurkechova 2023-05-17 13:15:55 UTC

Switched to Tested based on manual test results. Stepan feel free to test the package too. Thanks for helping us!

old:
===

[root@ci-vm-10-0-138-118 repo_server_val]# sos report -o subscription_manager

sosreport (version 4.5.1)

...

[root@ci-vm-10-0-138-118 repo_server_val]# cat redhat.repo 
proxy=http://proxy.example.com:3128/
proxy_username=foobar
proxy_password=hackme


new:
===
[root@ci-vm-10-0-136-145 ~]# sos report -o subscription_manager

sosreport (version 4.5.3)

...

[root@ci-vm-10-0-136-145 tmp]# cat sosreport-ci-vm-10-0-136-145-2023-05-17-smumlcm/var/lib/rhsm/repo_server_val/redhat.repo 
proxy=http://proxy.example.com:3128/
proxy_username=foobar
proxy_password=********

Comment 11 errata-xmlrpc 2023-05-31 18:49:38 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (sos bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:3414