Bug 2178003
| Summary: | Review Request: tomcat-jakartaee-migration - Tomcat Migration Tool for Jakarta EE | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | huwang <huwang> | ||||||
| Component: | Package Review | Assignee: | Socrates Zappis <szappis> | ||||||
| Status: | POST --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | package-review, szappis | ||||||
| Target Milestone: | --- | Flags: | szappis:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | http://tomcat.apache.org/ | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
huwang
2023-03-14 08:10:50 UTC
The scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=98648277 Copr build: https://copr.fedorainfracloud.org/coprs/build/5634889 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2178003-jakartaee-migration/fedora-rawhide-x86_64/05634889-jakartaee-migration/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. *** Bug 2178000 has been marked as a duplicate of this bug. *** I have changed the package name to tomcat-jakartaee-migration and fixed the patch command. Spec URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration.spec SRPM URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration-1.0.6-1.fc38.src.rpm Description: The purpose of the tool is to take a web application written for Java EE 8 that runs on Apache Tomcat 9 and convert it automatically so it runs on Apache Tomcat 10 which implements Jakarta EE 9. Fedora Account System Username: huwang The scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=109997254 Created attachment 2002982 [details]
The .spec file difference from Copr build 5634889 to 6730978
Copr build: https://copr.fedorainfracloud.org/coprs/build/6730978 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2178003-jakartaee-migration/fedora-rawhide-x86_64/06730978-tomcat-jakartaee-migration/fedora-review/review.txt Found issues: - License file ADDITIONAL_LICENSE_INFO is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Not a valid SPDX expression 'ASL 2.0'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local Read more: https://fedoraproject.org/wiki/Packaging:Java Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration.spec SRPM URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration-1.0.8-1.fc38.src.rpm Description: The purpose of the tool is to take a web application written for Java EE 8 that runs on Apache Tomcat 9 and convert it automatically so it runs on Apache Tomcat 10 which implements Jakarta EE 9. Fedora Account System Username: huwang The scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=113219331 New Spec and SRPM URLs, fedora-review-service-build. Spec URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration.spec SRPM URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration-1.0.8-1.fc38.src.rpm Description: The purpose of the tool is to take a web application written for Java EE 8 that runs on Apache Tomcat 9 and convert it automatically so it runs on Apache Tomcat 10 which implements Jakarta EE 9. Fedora Account System Username: huwang The scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=113219331 Copr build: https://copr.fedorainfracloud.org/coprs/build/7005482 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2178003-jakartaee-migration/fedora-rawhide-x86_64/07005482-tomcat-jakartaee-migration/fedora-review/review.txt Found issues: - License file ADDITIONAL_LICENSE_INFO is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/7005484 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2178003-jakartaee-migration/fedora-rawhide-x86_64/07005484-tomcat-jakartaee-migration/fedora-review/review.txt Found issues: - License file ADDITIONAL_LICENSE_INFO is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. @huwang the License file that the check is complaining about can be located in the noarch rpm under "/usr/share/javadoc/tomcat-jakartaee-migration/legal/" . I believe you will fix that by adding the following to your specfile under the "%files javadoc" section: "%license ADDITIONAL_LICENSE_INFO" New Spec and SRPM URLs, fedora-review-service-build. Spec URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration.spec SRPM URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration-1.0.8-1.fc38.src.rpm Description: The purpose of the tool is to take a web application written for Java EE 8 that runs on Apache Tomcat 9 and convert it automatically so it runs on Apache Tomcat 10 which implements Jakarta EE 9. Fedora Account System Username: huwang The scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=114286662 Created attachment 2019594 [details]
The .spec file difference from Copr build 7005484 to 7095095
Copr build: https://copr.fedorainfracloud.org/coprs/build/7095095 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2178003-jakartaee-migration/fedora-rawhide-x86_64/07095095-tomcat-jakartaee-migration/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. fedora-review-service-build Retry with [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/7106470 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2178003-jakartaee-migration/fedora-rawhide-x86_64/07106470-tomcat-jakartaee-migration/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is properly handled * No serious issues from rpmlint Package approved. The Pagure repository was created at https://src.fedoraproject.org/rpms/tomcat-jakartaee-migration |