Bug 217807

Summary:	Review Request: perl-Gtk2-Ex-Utils - Extra Gtk2 Utilities for working with Gnome2/Gtk2 in Perl
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Gtk2-Ex-Utils/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-11-30 06:49:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 217810

Description Chris Weyl 2006-11-29 23:12:41 UTC

SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-Utils-0.09-1.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-Utils.spec

Description:
This module provides simple utility functions useful for Gnome2/Gtk2 Perl
programming.

Comment 1 Parag AN(पराग) 2006-11-30 01:43:57 UTC

taking this for review

Comment 2 Parag AN(पराग) 2006-11-30 06:21:43 UTC

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPMS.
+ source files match upstream.
076bb6914470fb077f7028fef0a795f8  Gtk2-Ex-Utils-0.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage exists
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Followed perl packaging guidelines.
APPROVED.

Comment 3 Chris Weyl 2006-11-30 06:49:33 UTC

Imported and building for devel; branches requested for FC-[56].

Thanks for the review! :)